Bug 237444 - Push HTMLMediaElement renderer's contentBox rect to GPU process
Summary: Push HTMLMediaElement renderer's contentBox rect to GPU process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-03 12:44 PST by Eric Carlson
Modified: 2022-03-06 10:22 PST (History)
11 users (show)

See Also:


Attachments
Patch (16.79 KB, patch)
2022-03-03 12:58 PST, Eric Carlson
no flags Details | Formatted Diff | Diff
Patch for landing (16.82 KB, patch)
2022-03-03 17:35 PST, Eric Carlson
no flags Details | Formatted Diff | Diff
Patch for landing (16.82 KB, patch)
2022-03-06 08:23 PST, Eric Carlson
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2022-03-03 12:44:21 PST
The platform media player needs to know the render's content rect so size the video layer correctly
Comment 1 Eric Carlson 2022-03-03 12:44:53 PST
rdar://84869202
Comment 2 Eric Carlson 2022-03-03 12:58:45 PST
Created attachment 453780 [details]
Patch
Comment 3 Jer Noble 2022-03-03 17:17:54 PST
Comment on attachment 453780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453780&action=review

> Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:84
> +    ALWAYS_LOG(LOGIDENTIFIER);

Can we ALWAYS_LOG the size here as well?
Comment 4 Eric Carlson 2022-03-03 17:35:17 PST
Created attachment 453803 [details]
Patch for landing
Comment 5 EWS 2022-03-04 10:02:47 PST
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Comment 6 Eric Carlson 2022-03-06 08:23:22 PST
Created attachment 453931 [details]
Patch for landing
Comment 7 EWS 2022-03-06 09:29:34 PST
Committed r290874 (248105@main): <https://commits.webkit.org/248105@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453931 [details].