Bug 237441 - Fix broken SuspendExceptionScope and remove redundant VM::DeferExceptionScope.
Summary: Fix broken SuspendExceptionScope and remove redundant VM::DeferExceptionScope.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-03 12:03 PST by Mark Lam
Modified: 2022-03-05 10:56 PST (History)
10 users (show)

See Also:

Attachments
proposed patch. (10.67 KB, patch)
2022-03-03 12:10 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (10.67 KB, patch)
2022-03-03 12:13 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (10.67 KB, patch)
2022-03-03 12:15 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2022-03-03 12:03:21 PST 
SuspendExceptionScope was meant to do exactly the same things that VM::DeferExceptionScope does, except that SuspendExceptionScope hasn't been updated to handle exception handling via VMtraps bits.  This patch will fix SuspendExceptionScope to work like VM::DeferExceptionScope, and remove the now redundant VM::DeferExceptionScope.  SuspendExceptionScope is the better name here because the scope actually suspends any pending exception.  This is different from other Defer scopes where we prevent some new event from arising and defer the event to a later time.
Comment 1 Radar WebKit Bug Importer 2022-03-03 12:03:58 PST 
<rdar://problem/89769627>
Comment 2 Mark Lam 2022-03-03 12:10:24 PST 
Created attachment 453775 [details]
proposed patch.
Comment 3 Mark Lam 2022-03-03 12:13:55 PST 
Created attachment 453777 [details]
proposed patch.
Comment 4 Mark Lam 2022-03-03 12:15:29 PST 
Created attachment 453778 [details]
proposed patch.
Comment 5 Yusuke Suzuki 2022-03-03 13:09:57 PST 
Comment on attachment 453778 [details]
proposed patch.

r=me
Comment 6 Mark Lam 2022-03-05 10:19:31 PST 
Comment on attachment 453778 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 7 EWS 2022-03-05 10:56:28 PST 
Committed r290869 (248100@main): <https://commits.webkit.org/248100@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453778 [details].