RESOLVED FIXED 237441
Fix broken SuspendExceptionScope and remove redundant VM::DeferExceptionScope. 
https://bugs.webkit.org/show_bug.cgi?id=237441
Summary Fix broken SuspendExceptionScope and remove redundant VM::DeferExceptionScope.
Mark Lam
Reported 2022-03-03 12:03:21 PST
SuspendExceptionScope was meant to do exactly the same things that VM::DeferExceptionScope does, except that SuspendExceptionScope hasn't been updated to handle exception handling via VMtraps bits. This patch will fix SuspendExceptionScope to work like VM::DeferExceptionScope, and remove the now redundant VM::DeferExceptionScope. SuspendExceptionScope is the better name here because the scope actually suspends any pending exception. This is different from other Defer scopes where we prevent some new event from arising and defer the event to a later time.
Attachments
proposed patch. (10.67 KB, patch)
2022-03-03 12:10 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (10.67 KB, patch)
2022-03-03 12:13 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (10.67 KB, patch)
2022-03-03 12:15 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-03-03 12:03:58 PST
<rdar://problem/89769627>
Mark Lam
Comment 2 2022-03-03 12:10:24 PST
Created attachment 453775 [details] proposed patch.
Mark Lam
Comment 3 2022-03-03 12:13:55 PST
Created attachment 453777 [details] proposed patch.
Mark Lam
Comment 4 2022-03-03 12:15:29 PST
Created attachment 453778 [details] proposed patch.
Yusuke Suzuki
Comment 5 2022-03-03 13:09:57 PST
Comment on attachment 453778 [details] proposed patch. r=me
Mark Lam
Comment 6 2022-03-05 10:19:31 PST
Comment on attachment 453778 [details] proposed patch. Thanks for the review. Landing now.
EWS
Comment 7 2022-03-05 10:56:28 PST
Committed r290869 (248100@main): <https://commits.webkit.org/248100@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453778 [details].
Note You need to log in before you can comment on or make changes to this bug.