RESOLVED FIXED 237407
[iOS] Unable to scroll to a found text range when there is an existing selection 
https://bugs.webkit.org/show_bug.cgi?id=237407
Summary [iOS] Unable to scroll to a found text range when there is an existing selection
Aditya Keerthi
Reported 2022-03-02 22:00:23 PST
...
Attachments
Patch (8.25 KB, patch)
2022-03-02 22:02 PST, Aditya Keerthi 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Patch for landing (8.24 KB, patch)
2022-03-03 10:58 PST, Aditya Keerthi 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2022-03-02 22:00:39 PST
rdar://89653213
Aditya Keerthi
Comment 2 2022-03-02 22:02:53 PST
Created attachment 453696 [details] Patch
Wenson Hsieh
Comment 3 2022-03-03 09:31:09 PST
Comment on attachment 453696 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453696&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:600 > + TestWebKitAPI::Util::run(&scrollViewDelegate.get()->_finishedScrolling); Nit - I think you can remove the `.get()` here.
Aditya Keerthi
Comment 4 2022-03-03 10:58:19 PST
Created attachment 453761 [details] Patch for landing
Aditya Keerthi
Comment 5 2022-03-03 10:59:25 PST
(In reply to Wenson Hsieh from comment #3) > Comment on attachment 453696 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453696&action=review Thanks for the review! > > Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:600 > > + TestWebKitAPI::Util::run(&scrollViewDelegate.get()->_finishedScrolling); > > Nit - I think you can remove the `.get()` here. Removed.
EWS
Comment 6 2022-03-04 09:18:26 PST
Committed r290834 (248070@main): <https://commits.webkit.org/248070@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453761 [details].
Note You need to log in before you can comment on or make changes to this bug.