Bug 237407 - [iOS] Unable to scroll to a found text range when there is an existing selection
Summary: [iOS] Unable to scroll to a found text range when there is an existing selection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-02 22:00 PST by Aditya Keerthi
Modified: 2022-03-04 09:31 PST (History)
8 users (show)

See Also:

Attachments
Patch (8.25 KB, patch)
2022-03-02 22:02 PST, Aditya Keerthi 		wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch for landing (8.24 KB, patch)
2022-03-03 10:58 PST, Aditya Keerthi 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2022-03-02 22:00:23 PST 
...
Comment 1 Aditya Keerthi 2022-03-02 22:00:39 PST 
rdar://89653213
Comment 2 Aditya Keerthi 2022-03-02 22:02:53 PST 
Created attachment 453696 [details]
Patch
Comment 3 Wenson Hsieh 2022-03-03 09:31:09 PST 
Comment on attachment 453696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453696&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:600
> +    TestWebKitAPI::Util::run(&scrollViewDelegate.get()->_finishedScrolling);

Nit - I think you can remove the `.get()` here.
Comment 4 Aditya Keerthi 2022-03-03 10:58:19 PST 
Created attachment 453761 [details]
Patch for landing
Comment 5 Aditya Keerthi 2022-03-03 10:59:25 PST 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 453696 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=453696&action=review

Thanks for the review!

> > Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:600
> > +    TestWebKitAPI::Util::run(&scrollViewDelegate.get()->_finishedScrolling);
> 
> Nit - I think you can remove the `.get()` here.

Removed.
Comment 6 EWS 2022-03-04 09:18:26 PST 
Committed r290834 (248070@main): <https://commits.webkit.org/248070@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453761 [details].