Bug 237406 - [Style] Forbid spaces between type names and protocol names in Objective-C
Summary: [Style] Forbid spaces between type names and protocol names in Objective-C
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-02 20:34 PST by Myles C. Maxfield
Modified: 2022-03-03 10:22 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.70 KB, patch)
2022-03-02 20:36 PST, Myles C. Maxfield 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-03-02 20:34:19 PST 
[Style] Forbid spaces between type names and protocol names in Objective-C
Comment 1 Myles C. Maxfield 2022-03-02 20:36:13 PST 
Created attachment 453694 [details]
Patch
Comment 2 Darin Adler 2022-03-03 08:10:37 PST 
Comment on attachment 453694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453694&action=review

> Tools/Scripts/webkitpy/style/checkers/cpp.py:3420
> +    using_space_with_protocol = search(r'\Wid <', line)

Is \W better than \b for this?
Comment 3 Myles C. Maxfield 2022-03-03 08:57:08 PST 
Comment on attachment 453694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453694&action=review

>> Tools/Scripts/webkitpy/style/checkers/cpp.py:3420
>> +    using_space_with_protocol = search(r'\Wid <', line)
> 
> Is \W better than \b for this?

\b is probably better. I’ll update before landing.
Comment 4 Myles C. Maxfield 2022-03-03 10:21:14 PST 
Committed r290784 (248028@trunk): <https://commits.webkit.org/248028@trunk>
Comment 5 Radar WebKit Bug Importer 2022-03-03 10:22:17 PST 
<rdar://problem/89762953>