Bug 237400 - Rename RenderStyle::textDecoration() to RenderStyle::textDecorationLine()
Summary: Rename RenderStyle::textDecoration() to RenderStyle::textDecorationLine()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oriol Brufau
URL:
Keywords: InRadar
Depends on: 237175
Blocks:
  Show dependency tree / graph
 
Reported: 2022-03-02 16:41 PST by Oriol Brufau
Modified: 2022-03-14 17:43 PDT (History)
28 users (show)

See Also:

Attachments
Patch (26.27 KB, patch)
2022-03-02 16:52 PST, Oriol Brufau 		no flags Details | Formatted Diff | Diff
Patch (26.33 KB, patch)
2022-03-14 16:17 PDT, Oriol Brufau 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oriol Brufau 2022-03-02 16:41:17 PST 
Before https://webkit.org/b/237175, the text-decoration-line and text-decoration properties were 2 longhands that shared a computed value, accessed via RenderStyle::textDecoration().

But now text-decoration is a proper shorthand, and it expands to text-decoration-line, text-decoration-color, etc. So it doesn't make much sense to continue accessing the line via textDecoration(), it should be textDecorationLine() instead.

Same for RenderStyle::setTextDecoration(), etc.
Comment 1 Oriol Brufau 2022-03-02 16:52:42 PST 
Created attachment 453679 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-03-09 16:42:15 PST 
<rdar://problem/90065611>
Comment 3 EWS 2022-03-14 16:11:59 PDT 
Tools/Scripts/svn-apply failed to apply attachment 453679 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 4 Oriol Brufau 2022-03-14 16:17:38 PDT 
Created attachment 454633 [details]
Patch
Comment 5 EWS 2022-03-14 17:43:10 PDT 
Committed r291257 (248409@main): <https://commits.webkit.org/248409@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454633 [details].