Bug 237399 – [WebAuthn] Give Storage Access API whenever user accepts cross-origin Webauthn prompt

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit Misc.

[[e-mail]]

This is needed for cross-origin authenticating i-frames to use cookies.

[Radar WebKit Bug Importer]

<rdar://problem/89719739>

[John Wilander]

It's important that anything that opens up storage access uses prompt language that makes cross-site tracking capabilities clear.

[[e-mail]]

Created attachment 455067 [details]
Patch

[Brent Fulgham]

Comment on attachment 455067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455067&action=review

r=me

> Source/WebKit/ChangeLog:10
> +        assertion. On the apple port, the prompt required for cross-origin assertions includes

Nit: 'Apple' port

> Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp:62
> +            crossOriginParent = document->securityOrigin().data();

Are these ever different when the 'isSameOriginAs' test passes? I wonder if this part of the change is needed.

[[e-mail]]

(In reply to Brent Fulgham from comment #4)
> > Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp:62
> > +            crossOriginParent = document->securityOrigin().data();
> 
> Are these ever different when the 'isSameOriginAs' test passes? I wonder if
> this part of the change is needed.

They are different here because the check above checks that isSameOriginAs doesn't pass.

> if (!crossOriginParent && !origin.isSameOriginAs(document->securityOrigin()))

Thank you for the review.

[[e-mail]]

Created attachment 455120 [details]
Patch for landing

[Brent Fulgham]

After further discussion, this will be handled a different way.