Bug 237390 - [AppSSO] Correct logging messages to avoid confusing screeners that an error has occurred
Summary: [AppSSO] Correct logging messages to avoid confusing screeners that an error ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-02 13:50 PST by Brent Fulgham
Modified: 2024-07-13 12:35 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.82 KB, patch)
2022-03-02 14:02 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2022-03-02 13:50:17 PST 
The phrasing of the message in 'SOAuthorizationCoordinator::tryAuthorize' when a URL is not relevant for AppSSO flows is:

        AUTHORIZATIONCOORDINATOR_RELEASE_LOG("tryAuthorize: Cannot authorize the requested URL.");

This leads people spelunking logs to believe that the URL can't be authorized (perhaps due to an error).

Instead, we should more accurately report that the URL is not one that is mediated through an AppSSO flow, and so no AppSSO processing is needed.
Comment 1 Radar WebKit Bug Importer 2022-03-02 13:51:49 PST 
<rdar://problem/89710486>
Comment 2 Brent Fulgham 2022-03-02 14:02:08 PST 
Created attachment 453657 [details]
Patch
Comment 3 EWS 2022-03-02 15:26:26 PST 
Committed r290758 (248002@main): <https://commits.webkit.org/248002@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453657 [details].