Bug 23738 - Add the ability to determine what the target string is in a hit test.
Summary: Add the ability to determine what the target string is in a hit test.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-04 12:58 PST by Benjamin Meyer
Modified: 2009-02-13 06:46 PST (History)
2 users (show)

See Also:


Attachments
webkit patch (4.47 KB, patch)
2009-02-12 12:55 PST, Benjamin Meyer
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Meyer 2009-02-04 12:58:45 PST
Currently in the QWebHitTest you can get a pointer to the QWebFrame that the target link points to.  This is nice that the string is automatically converted to the frame, but when the frame is 0 because the target string is not necessarily _blank, but could be a bad frame name such as foobar.  This patch adds a function to QWebHitTest to return the string name.  Included is a test for it.

http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=commit;h=05088d2fb9c454ff9e5029985eb35e1707d0a2d0
Comment 1 Nikolas Zimmermann 2009-02-04 13:10:24 PST
Looks just fine to me. You need to upload a patch though, best is to apply your patch to a WebKit trunk checkout. Run prepare-ChangeLog, edit ChangeLog, use svn-create-patch and then upload the resulting patch here, I'll r+ it then.
Comment 2 Benjamin Meyer 2009-02-12 12:55:42 PST
Created attachment 27622 [details]
webkit patch
Comment 3 Nikolas Zimmermann 2009-02-12 14:31:23 PST
Comment on attachment 27622 [details]
webkit patch

r=me.
Comment 4 Adam Treat 2009-02-13 06:46:43 PST
Committed with r40973 with slight change for the qdocs saying this is introduced in 4.6+.