Bug 237379 - rdar://89579689: Define DEPLOYMENT_TARGET_CLANG_ENV_NAME in the legacy build system
Summary: rdar://89579689: Define DEPLOYMENT_TARGET_CLANG_ENV_NAME in the legacy build ...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-02 11:01 PST by Elliott Williams
Modified: 2022-03-02 11:38 PST (History)
4 users (show)

See Also:

Attachments
Patch (14.14 KB, patch)
2022-03-02 11:05 PST, Elliott Williams 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-03-02 11:01:11 PST 
rdar://89579689: Define DEPLOYMENT_TARGET_CLANG_ENV_NAME in the legacy build system
Comment 1 Elliott Williams 2022-03-02 11:01:52 PST 
rdar://89579689
Comment 2 Elliott Williams 2022-03-02 11:05:00 PST 
Created attachment 453639 [details]
Patch
Comment 3 Elliott Williams 2022-03-02 11:05:03 PST 
<rdar://problem/89579689>
Comment 4 Alexey Proskuryakov 2022-03-02 11:08:05 PST 
Comment on attachment 453639 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453639&action=review

> Source/WTF/Configurations/Base.xcconfig:116
> +DEPLOYMENT_TARGET_CLANG_ENV_NAME_legacy[sdk=watch*] = WATCHOS_DEPLOYMENT_TARGET;

Don't we need tvOS all over the place?

I also wonder if a temporary hack in HaveInternalSDK.xcconfig would be better than having this all over the place.
Comment 5 Elliott Williams 2022-03-02 11:38:02 PST 
Good idea. Let's hack in HaveInternalSDK.xcconfig, as this is an internal-only Xcode bug.