Bug 237378 - Rendering issues with many dynamically-added sticky elements inside overflow scroll
Summary: Rendering issues with many dynamically-added sticky elements inside overflow ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-02 10:35 PST by Simon Fraser (smfr)
Modified: 2022-03-02 16:11 PST (History)
9 users (show)

See Also:


Attachments
Patch (10.11 KB, patch)
2022-03-02 10:48 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-03-02 10:35:30 PST
Rendering issues with many dynamically-added sticky elements in a table
Comment 1 Simon Fraser (smfr) 2022-03-02 10:48:20 PST
Created attachment 453636 [details]
Patch
Comment 2 Cameron McCormack (:heycam) 2022-03-02 15:43:32 PST
Comment on attachment 453636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453636&action=review

r=me though I didn't read the tests closely.

> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:382
> +    if (!rootStateNode())
> +        return emptyString();

It's an unlikely error case but you might still want to log m_unparentedNodes even if we have no root node?
Comment 3 EWS 2022-03-02 16:10:08 PST
Committed r290760 (248004@main): <https://commits.webkit.org/248004@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453636 [details].
Comment 4 Radar WebKit Bug Importer 2022-03-02 16:11:31 PST
<rdar://problem/89718573>