Bug 23737 - HTMLMediaElement should encapsulate more of the logic needed by default controller
: HTMLMediaElement should encapsulate more of the logic needed by default contr...
Status: RESOLVED FIXED
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-02-04 12:57 PST by
Modified: 2009-03-02 11:51 PST (History)


Attachments
proposed patch (8.35 KB, patch)
2009-02-04 13:48 PST, Eric Carlson
koivisto: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-02-04 12:57:05 PST
Too much HTMLMediaElement internal state and logic is needed by MediaControlElements and RenderMedia to implement the default media controls. The media element should offer higher level methods to keep this state internal so it will be easier to change the logic when we update to the current spec.
------- Comment #1 From 2009-02-04 13:48:28 PST -------
Created an attachment (id=27324) [details]
proposed patch
------- Comment #2 From 2009-02-09 09:43:13 PST -------
(From update of attachment 27324 [details])
r=me

> +    if (m_pausedInternal) {
> +        setPausedInternal(false);
> +    }

No need for {}
------- Comment #3 From 2009-02-09 11:50:37 PST -------
Committed revision 40789