RESOLVED FIXED 23737
HTMLMediaElement should encapsulate more of the logic needed by default controller
https://bugs.webkit.org/show_bug.cgi?id=23737
Summary HTMLMediaElement should encapsulate more of the logic needed by default contr...
Eric Carlson
Reported 2009-02-04 12:57:05 PST
Too much HTMLMediaElement internal state and logic is needed by MediaControlElements and RenderMedia to implement the default media controls. The media element should offer higher level methods to keep this state internal so it will be easier to change the logic when we update to the current spec.
Attachments
proposed patch (8.35 KB, patch)
2009-02-04 13:48 PST, Eric Carlson
koivisto: review+
Eric Carlson
Comment 1 2009-02-04 13:48:28 PST
Created attachment 27324 [details] proposed patch
Antti Koivisto
Comment 2 2009-02-09 09:43:13 PST
Comment on attachment 27324 [details] proposed patch r=me > + if (m_pausedInternal) { > + setPausedInternal(false); > + } No need for {}
Eric Carlson
Comment 3 2009-02-09 11:50:37 PST
Committed revision 40789
Note You need to log in before you can comment on or make changes to this bug.