Bug 237357 – [web-animations] changes to font-size should recompute keyframes

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

[web-animations] changes to font-size should recompute keyframes

[Antoine Quint]

Created attachment 453580 [details]
Patch

[Antoine Quint]

Created attachment 453581 [details]
Patch

[Antti Koivisto]

Comment on attachment 453581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453581&action=review

> Source/WebCore/animation/KeyframeEffectStack.cpp:146
> -        if (propertyAffectingLogicalPropertiesChanged)
> -            effect->propertyAffectingLogicalPropertiesDidChange(unanimatedStyle, resolutionContext);
> +        if (propertyAffectingLogicalPropertiesChanged || fontSizeChanged)
> +            effect->propertyAffectingKeyframeResolutionDidChange(unanimatedStyle, resolutionContext);

This is probably incomplete as various other things can affect unit resolution (like zoom property).

[Antoine Quint]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 453581 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=453581&action=review
> 
> > Source/WebCore/animation/KeyframeEffectStack.cpp:146
> > -        if (propertyAffectingLogicalPropertiesChanged)
> > -            effect->propertyAffectingLogicalPropertiesDidChange(unanimatedStyle, resolutionContext);
> > +        if (propertyAffectingLogicalPropertiesChanged || fontSizeChanged)
> > +            effect->propertyAffectingKeyframeResolutionDidChange(unanimatedStyle, resolutionContext);
> 
> This is probably incomplete as various other things can affect unit
> resolution (like zoom property).

Excellent! Do you know of others?

[Antoine Quint]

Created attachment 453588 [details]
Patch

[Antti Koivisto]

> Excellent! Do you know of others?

Stuff that shows up in CSSPrimitiveValue::computeNonCalcLengthDouble and pals I suppose.

[EWS]

Committed r290730 (247977@main): <https://commits.webkit.org/247977@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453588 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89686859>