Bug 237357 - [web-animations] changes to font-size should recompute keyframes
Summary: [web-animations] changes to font-size should recompute keyframes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar, WebExposed, WPTImpact
Depends on:
Blocks:
 
Reported: 2022-03-02 01:37 PST by Antoine Quint
Modified: 2022-03-02 07:40 PST (History)
4 users (show)

See Also:

Attachments
Patch (11.60 KB, patch)
2022-03-02 01:40 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (12.62 KB, patch)
2022-03-02 01:47 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (18.11 KB, patch)
2022-03-02 04:40 PST, Antoine Quint 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-03-02 01:37:29 PST 
[web-animations] changes to font-size should recompute keyframes
Comment 1 Antoine Quint 2022-03-02 01:40:55 PST 
Created attachment 453580 [details]
Patch
Comment 2 Antoine Quint 2022-03-02 01:47:24 PST 
Created attachment 453581 [details]
Patch
Comment 3 Antti Koivisto 2022-03-02 02:13:46 PST 
Comment on attachment 453581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453581&action=review

> Source/WebCore/animation/KeyframeEffectStack.cpp:146
> -        if (propertyAffectingLogicalPropertiesChanged)
> -            effect->propertyAffectingLogicalPropertiesDidChange(unanimatedStyle, resolutionContext);
> +        if (propertyAffectingLogicalPropertiesChanged || fontSizeChanged)
> +            effect->propertyAffectingKeyframeResolutionDidChange(unanimatedStyle, resolutionContext);

This is probably incomplete as various other things can affect unit resolution (like zoom property).
Comment 4 Antoine Quint 2022-03-02 02:17:42 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 453581 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=453581&action=review
> 
> > Source/WebCore/animation/KeyframeEffectStack.cpp:146
> > -        if (propertyAffectingLogicalPropertiesChanged)
> > -            effect->propertyAffectingLogicalPropertiesDidChange(unanimatedStyle, resolutionContext);
> > +        if (propertyAffectingLogicalPropertiesChanged || fontSizeChanged)
> > +            effect->propertyAffectingKeyframeResolutionDidChange(unanimatedStyle, resolutionContext);
> 
> This is probably incomplete as various other things can affect unit
> resolution (like zoom property).

Excellent! Do you know of others?
Comment 5 Antoine Quint 2022-03-02 04:40:04 PST 
Created attachment 453588 [details]
Patch
Comment 6 Antti Koivisto 2022-03-02 04:53:29 PST 
> Excellent! Do you know of others?

Stuff that shows up in CSSPrimitiveValue::computeNonCalcLengthDouble and pals I suppose.
Comment 7 EWS 2022-03-02 07:29:16 PST 
Committed r290730 (247977@main): <https://commits.webkit.org/247977@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453588 [details].
Comment 8 Radar WebKit Bug Importer 2022-03-02 07:30:20 PST 
<rdar://problem/89686859>