Bug 237353 – Add test coverage for deleting FileSystem data when file is being written

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Sihui Liu]

...

[Sihui Liu]

Created attachment 453572 [details]
Patch

[Chris Dumez]

Comment on attachment 453572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453572&action=review

> Tools/ChangeLog:8
> +        Verify that file can be removed from disk, and active FileSystemSyncAccessHandle is invalidated in ths case.

Typo: "ths"

> Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:208
> +        RetainPtr<NSData> data;

Why declare the variable here?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:212
> +        data = [NSData dataWithBytes:workerBytes length:strlen(workerBytes)];

RetainPtr data = [NSData dataWithBytes:workerBytes length:strlen(workerBytes)];

[Sihui Liu]

Comment on attachment 453572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453572&action=review

>> Tools/ChangeLog:8
>> +        Verify that file can be removed from disk, and active FileSystemSyncAccessHandle is invalidated in ths case.
> 
> Typo: "ths"

Will change.

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:212
>> +        data = [NSData dataWithBytes:workerBytes length:strlen(workerBytes)];
> 
> RetainPtr data = [NSData dataWithBytes:workerBytes length:strlen(workerBytes)];

Sure, will change.

[Sihui Liu]

Created attachment 453628 [details]
Patch for landing

[Sihui Liu]

Created attachment 453629 [details]
Patch for landing

[EWS]

Committed r290736 (247983@main): <https://commits.webkit.org/247983@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453629 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89698883>