Bug 237346 – REGRESSION(r290539): [ iOS ] 2X http/wpt/webauthn/public-key-credential-create-failure-local (layout-tests) are constant text failures

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Robert Jenner]

The following two http/wpt/webauthn/public-key-credential-create-failure-local layout-tests are constant text failures on iOS. 

http/wpt/webauthn/public-key-credential-create-failure-local.https.html
http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html

HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=http%2Fwpt%2Fwebauthn%2Fpublic-key-credential-create-failure-local-silent.https.html&test=http%2Fwpt%2Fwebauthn%2Fpublic-key-credential-create-failure-local.https.html

The diff appears to be the same for both tests. 

TEXT DIFF:
 PASS PublicKeyCredential's [[create]] with matched exclude credentials in a mock local authenticator. 2nd
 PASS PublicKeyCredential's [[create]] without user consent in a mock local authenticator.
 PASS PublicKeyCredential's [[create]] without private keys in a mock local authenticator.
-PASS PublicKeyCredential's [[create]] without attestation in a mock local authenticator.
+FAIL PublicKeyCredential's [[create]] without attestation in a mock local authenticator. assert_unreached: Should have rejected: Couldn't attest: The operation couldn't complete. Reached unreachable code. 

DIFF URLS:
https://build.webkit.org/results/Apple-iOS-15-Simulator-Debug-WK2-Tests/r290667%20(1795)/http/wpt/webauthn/public-key-credential-create-failure-local.https-pretty-diff.html
https://build.webkit.org/results/Apple-iOS-15-Simulator-Debug-WK2-Tests/r290667%20(1795)/http/wpt/webauthn/public-key-credential-create-failure-local-silent.https-pretty-diff.html

[Radar WebKit Bug Importer]

<rdar://problem/89647260>

[Dawn Morningstar]

My bug https://bugs.webkit.org/show_bug.cgi?id=237345 is the same as this one, but this one includes the second test so I am marking mine as a duplicate.

[[e-mail]]

Created attachment 453546 [details]
Patch

[Dawn Morningstar]

*** Bug 237345 has been marked as a duplicate of this bug. ***

[Brent Fulgham]

Comment on attachment 453546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453546&action=review

r=me

> LayoutTests/ChangeLog:10
> +        we've changed behavior such that creation still succeeds with none attestation

Nit: Maybe say: "... succeeds with 'none' attestation in this case..."

[[e-mail]]

Created attachment 453637 [details]
Patch for landing

[EWS]

Committed r290751 (247995@main): <https://commits.webkit.org/247995@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453637 [details].

[Dawn Morningstar]

http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html and
http/wpt/webauthn/public-key-credential-create-failure-local.https.html 

Still appear to be constantly failing.