Bug 23731 – Add JSCCustom and V8Custom as extended IDL attributes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Darin Fisher (:fishd, Google)]

Add JSCCustom and V8Custom as extended IDL attributes

This will help avoid having to add #ifdefs to the IDL files to support the V8 bindings.

[Darin Fisher (:fishd, Google)]

Created attachment 27316 [details]
v1 patch

In this patch, I define JSCCustom and make use of it in a few IDL files.  I also modify Document.idl to make use of V8Custom, which is known only to the CodeGeneratorV8.pm module (that has yet to be upstreamed).

I did not add JSCCustomGetter or JSCCustomSetter since they are not needed.  I could add those for completeness, but it seemed better to just focus on what is actually needed.

[Darin Adler]

Comment on attachment 27316 [details]
v1 patch

>              $numCustomAttributes++ if $attribute->signature->extendedAttributes->{"Custom"};
>              $numCustomAttributes++ if $attribute->signature->extendedAttributes->{"CustomGetter"};
>              $numCustomAttributes++ if $attribute->signature->extendedAttributes->{"CustomSetter"};
> +            $numCustomAttributes++ if $attribute->signature->extendedAttributes->{"JSCCustom"};

This will do the wrong thing if someone includes both "Custom" and "JSCustom" for the same attribute; and it won't report an error. It would be better to use || instead or consider it an error.

>          $numCustomFunctions++ if $function->signature->extendedAttributes->{"Custom"};
> +        $numCustomFunctions++ if $function->signature->extendedAttributes->{"JSCCustom"};

Same comment.

r=me

[Darin Fisher (:fishd, Google)]

Good catch.  Thanks!

[Darin Fisher (:fishd, Google)]

http://trac.webkit.org/changeset/40617