RESOLVED FIXED237300
Move StorageBucket function definitions outside the class definition 
https://bugs.webkit.org/show_bug.cgi?id=237300
Summary Move StorageBucket function definitions outside the class definition
Sihui Liu
Reported 2022-02-28 18:31:27 PST
...
Attachments
Patch (29.77 KB, patch)
2022-02-28 19:51 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (29.83 KB, patch)
2022-03-01 11:44 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (29.81 KB, patch)
2022-03-01 11:58 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2022-02-28 19:51:20 PST
Created attachment 453466 [details] Patch
Chris Dumez
Comment 2 2022-03-01 07:59:09 PST
Comment on attachment 453466 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453466&action=review r=me > Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:115 > + return ""_s; emptyString() > Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:166 > + return m_localStorageManager.get(); This is a one liner, I think we should keep it inline within the class definition. > Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:179 > + return m_sessionStorageManager.get(); ditto. > Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:192 > + return m_idbStorageManager.get(); ditto.
Sihui Liu
Comment 3 2022-03-01 11:44:41 PST
Created attachment 453515 [details] Patch for landing
Sihui Liu
Comment 4 2022-03-01 11:58:44 PST
Created attachment 453516 [details] Patch for landing
EWS
Comment 5 2022-03-01 12:59:07 PST
Committed r290669 (?): <https://commits.webkit.org/r290669> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453516 [details].
Radar WebKit Bug Importer
Comment 6 2022-03-01 13:00:29 PST
<rdar://problem/89636878>
Note You need to log in before you can comment on or make changes to this bug.