Bug 237292 – [GTK] setDragImage ignores offset

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Per Bothner]

Created attachment 453436 [details]
test of setDragImage offset

WebKitGtk (Epiphany/Gnome Web and Wry, tested on Fedora 35, updated) seem to ignore the xOffset/yOffset parameters passed to setDragImage.
The strange thing is that Safari works (tested on Catalina, updated) - and both report version 605.1.15.
FireFox and Google Chrome work as expected.

To reproduce, view the attached file in a browser. Do a mousedown over the word "here" and then drag the mouse without releasing.
A drag image is created of the "Drag here"+"Lower contents" elements, and follows the mouse as expected.
However, the image of the word "here" is supposed to be under the mouse cursor.
Instead the drag image is displaced so the center of the drag image is under the mouse cursor.

[Michael Catanzaro]

Looks like we need to somehow plumb the coordinates from WebCore::DataTransfer::updateDragImage and WebCore::DataTransfer::createDragImage, where they're available, to WebKit::DragSource::begin (both GTK 3 and GTK 4 versions), where they're needed but don't seem to be available. The GTK 3 version uses cairo_surface_set_device_offset() to center the image, while the GTK 4 version uses gdk_drag_set_hotspot().

[Michael Catanzaro]

Thanks for the good example/test. This helped a lot.

[Michael Catanzaro]

Created attachment 453531 [details]
Patch

[Michael Catanzaro]

Created attachment 453543 [details]
Patch

[EWS]

Committed r290728 (247975@main): <https://commits.webkit.org/247975@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453543 [details].

[Per Bothner]

Thanks for the quick fix! Looking forward to it appearing in Fedora and other distributions.