Bug 237285 - REGRESSION(r290539-r290538): [ iOS ] 3 TestWebKitAPI.WebAuthenticationPanel.* tests are constantly failing/crashing.
Summary: REGRESSION(r290539-r290538): [ iOS ] 3 TestWebKitAPI.WebAuthenticationPanel.*...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: pascoe@apple.com
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-28 13:39 PST by Dawn Morningstar
Modified: 2022-03-01 09:41 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.34 KB, patch)
2022-02-28 15:13 PST, pascoe@apple.com 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dawn Morningstar 2022-02-28 13:39:39 PST 
TestWebKitAPI.WebAuthenticationPanel.UpdateCredentialUsername
TestWebKitAPI.WebAuthenticationPanel.LAMakeCredentialRollBackCredential
TestWebKitAPI.WebAuthenticationPanel.LANoCredential 
Are constantly failing/crashing on iOS.

HISTORY:
https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebAuthenticationPanel.UpdateCredentialUsername&test=TestWebKitAPI.WebAuthenticationPanel.LAMakeCredentialRollBackCredential&test=TestWebKitAPI.WebAuthenticationPanel.LANoCredential

Regression range appears to be r290539-r290538.

Related to https://bugs.webkit.org/show_bug.cgi?id=237223
Comment 1 Dawn Morningstar 2022-02-28 13:42:13 PST 
At iOS Debug TOT TestWebKitAPI.WebAuthenticationPanel.UpdateCredentialUsername passes, TestWebKitAPI.WebAuthenticationPanel.LAMakeCredentialRollBackCredential and TestWebKitAPI.WebAuthenticationPanel.LANoCredential provide an  ASSERTION FAILED: databaseUpdated error.

These results continue even before suspected regression point. Results still the same at r290539 r290538 and r290537.
Comment 2 Radar WebKit Bug Importer 2022-02-28 13:51:15 PST 
<rdar://problem/89579460>
Comment 3 pascoe@apple.com 2022-02-28 15:13:33 PST 
Created attachment 453440 [details]
Patch
Comment 4 pascoe@apple.com 2022-02-28 15:54:49 PST 
This is caused by LAMakeCredentialRollBackCredential being obsolete, but still creating a credential before failing, which causes the other two tests to fail / timeout as well.
Comment 5 Brent Fulgham 2022-03-01 08:48:24 PST 
Comment on attachment 453440 [details]
Patch

r=me
Comment 6 EWS 2022-03-01 09:41:46 PST 
Committed r290652 (247925@main): <https://commits.webkit.org/247925@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453440 [details].