Bug 237283 – Migrate third-party IndexedDB data to GeneralStorageDirectory

• Status: RESOLVED
• Resolution: FIXED
• Component: Website Storage

[Sihui Liu]

...

[Sihui Liu]

Created attachment 453422 [details]
Patch

[Chris Dumez]

Comment on attachment 453422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453422&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:407
> +    auto preferences = (__bridge WKPreferencesRef)[configuration preferences];

Why cast to C API?

Let's just use the Cocoa API:
`[[configuration preferences] _setStorageBlockingPolicy:_WKStorageBlockingPolicyAllowAll];`

You may have to include WKPreferencesPrivate.h if not already included.

Mixing C and Cocoa API is a bit ugly :)

[Sihui Liu]

Comment on attachment 453422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453422&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:407
>> +    auto preferences = (__bridge WKPreferencesRef)[configuration preferences];
> 
> Why cast to C API?
> 
> Let's just use the Cocoa API:
> `[[configuration preferences] _setStorageBlockingPolicy:_WKStorageBlockingPolicyAllowAll];`
> 
> You may have to include WKPreferencesPrivate.h if not already included.
> 
> Mixing C and Cocoa API is a bit ugly :)

Sure :) I didn't see the Cocoa API

[Sihui Liu]

Created attachment 453477 [details]
Patch for landing

[EWS]

Committed r290632 (247905@main): <https://commits.webkit.org/247905@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453477 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89605260>