Bug 237282 – Haiku port upstreaming: Webkitpy

• Status: NEW
• Component: Tools / Tests

[Pascal Abresch]

This ticket is for upstreaming the webkitpy portiong of the Haiku port to webkit.

[Pascal Abresch]

Created attachment 453411 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/89918574>

[Jonathan Bedard]

Comment on attachment 453411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453411&action=review

> Tools/Scripts/webkitpy/port/haikudriver.py:1
> +# Copyright (C) 2010 Google Inc. All rights reserved.

Feels like this copyright needs to be updated, no?

[Pascal Abresch]

Indeed.
Pulkomandy: It looks like you added this file in 2013 (in https://github.com/haiku/webkit-old/commit/cd80529000af2ab10470c24197d1198b078b0257)
Do you have any particular opinion on changing the copyright header?

[Adrien Destugues]

The files were initially copied from other ports which explain the copyright.

You can add a copyright for 2013-2022 to Haiku, inc.

[Pascal Abresch]

Created attachment 454528 [details]
Patch

[Pascal Abresch]

I have updated the copyright dates accordingly.

[Jonathan Bedard]

No objection to this change, would like to understand the plan with Haiku upstreaming, though. Is there an intention to have bots at some point? This code is mostly used for running layout tests. Are the Haiku folks already doing this? Is there an intention to do this>

[Adrien Destugues]

Hello,

Haiku inc is willing to provide a machine to run the bots for Haiku as needed.

Until now I have run the tests locally on my machine only. Now that Pascal is helping me with the WebKit work, it's a bit more reasonable to work on upstreaming our changes (or at least some of it). There has been some discussions in https://bugs.webkit.org/show_bug.cgi?id=220690 about wether WebKit would accept all our port in upstream again, or only a subset.

So, yes, if we're allowed to submit our port upstream, we will of course provide the needed bots and have them run the tests.

[Jonathan Bedard]

Comment on attachment 454528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454528&action=review

> Tools/Scripts/webkitpy/common/version_name_map.py:79
> +            'haiku': {'': Version(1.4)},

Should be: `Version(1, 4)`

> Tools/Scripts/webkitpy/port/haiku.py:47
> +        self._version = "1.4"

Looking through our webkitpy code, it looks to me like the ApplePort doesn't use this variable, do things work without it?

[Pascal Abresch]

Hey, sorry for the late response.
I don't know if the second variable is needed, I'll remove it locally and try to run the tests and resubmit it without it if it is uneccesary.