Bug 237269 – allow-custom-protocols-navigation sandbox flag.

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Arthur Sonzogni]

Feature request: https://github.com/whatwg/html/pull/7654

The freshly minted "allow-custom-protocols-navigation" would navigations toward external applications to continue to work inside a sandboxed iframe. 

This is a follow-up to:
https://bugs.webkit.org/show_bug.cgi?id=231727
which has been implemented in Webkit with quirks for microsoft team. Implementing it would allow removing the quirk, once Microsoft Team start using it.

[Radar WebKit Bug Importer]

<rdar://problem/89899736>

[Chris Dumez]

Created attachment 453995 [details]
Patch

[Geoffrey Garen]

Comment on attachment 453995 [details]
Patch

r=me

[EWS]

Committed r290958 (248140@main): <https://commits.webkit.org/248140@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453995 [details].

[Arthur Sonzogni]

Hi Chris,

You landed "allow-custom-protocols-navigation". Great!

This was the initial name, but it changed to:
"allow-top-navigation-to-custom-protocols"

This was requested here:
https://github.com/whatwg/html/pull/7654#issuecomment-1054219407

You probably want to make a correction to your patch.

[Chris Dumez]

(In reply to Arthur Sonzogni from comment #5)
> Hi Chris,
> 
> You landed "allow-custom-protocols-navigation". Great!
> 
> This was the initial name, but it changed to:
> "allow-top-navigation-to-custom-protocols"
> 
> This was requested here:
> https://github.com/whatwg/html/pull/7654#issuecomment-1054219407
> 
> You probably want to make a correction to your patch.

Ouch! Thanks for pointing this out. I'll follow-up.

[Chris Dumez]

(In reply to Chris Dumez from comment #6)
> (In reply to Arthur Sonzogni from comment #5)
> > Hi Chris,
> > 
> > You landed "allow-custom-protocols-navigation". Great!
> > 
> > This was the initial name, but it changed to:
> > "allow-top-navigation-to-custom-protocols"
> > 
> > This was requested here:
> > https://github.com/whatwg/html/pull/7654#issuecomment-1054219407
> > 
> > You probably want to make a correction to your patch.
> 
> Ouch! Thanks for pointing this out. I'll follow-up.

Following up in Bug 237605.