Bug 237267 - Introduce routines to exchange SharedVideoFrame::Buffer directly
Summary: Introduce routines to exchange SharedVideoFrame::Buffer directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-27 23:45 PST by youenn fablet
Modified: 2022-03-04 01:17 PST (History)
8 users (show)

See Also:

Attachments
Patch (36.22 KB, patch)
2022-02-27 23:53 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (35.82 KB, patch)
2022-02-28 01:37 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (35.23 KB, patch)
2022-03-01 04:01 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (35.23 KB, patch)
2022-03-01 07:15 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (35.39 KB, patch)
2022-03-03 04:25 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-02-27 23:45:18 PST 
Introduce routines to exchange SharedVideoFrame::Buffer directly
Comment 1 youenn fablet 2022-02-27 23:53:32 PST 
Created attachment 453371 [details]
Patch
Comment 2 youenn fablet 2022-02-28 01:37:11 PST 
Created attachment 453375 [details]
Patch
Comment 3 youenn fablet 2022-03-01 04:01:11 PST 
Created attachment 453488 [details]
Patch
Comment 4 youenn fablet 2022-03-01 07:15:31 PST 
Created attachment 453497 [details]
Patch
Comment 5 youenn fablet 2022-03-02 06:55:41 PST 
Ping review.
Comment 6 Eric Carlson 2022-03-02 08:28:44 PST 
Comment on attachment 453497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453497&action=review

> Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:109
> +    auto videoFrame = get(WTFMove(read));

Obviously this isn't new to this patch, but reading this made me realize that RemoteVideoFrameObjectHeap::get is a confusing name because `get` RefPtr::get and Ref::get are so widely used in WebKit and don't mean the same thing at all.

> Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:248
> +            m_videoFrameObjectHeap->get(WTFMove(std::get<RemoteVideoFrameReadReference>(sharedVideoFrame.buffer)));

Ditto.
Comment 7 youenn fablet 2022-03-03 04:25:14 PST 
Created attachment 453718 [details]
Patch for landing
Comment 8 EWS 2022-03-04 01:16:17 PST 
Committed r290824 (248060@main): <https://commits.webkit.org/248060@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453718 [details].
Comment 9 Radar WebKit Bug Importer 2022-03-04 01:17:19 PST 
<rdar://problem/89802729>