Bug 237267 – Introduce routines to exchange SharedVideoFrame::Buffer directly

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Introduce routines to exchange SharedVideoFrame::Buffer directly

[youenn fablet]

Created attachment 453371 [details]
Patch

[youenn fablet]

Created attachment 453375 [details]
Patch

[youenn fablet]

Created attachment 453488 [details]
Patch

[youenn fablet]

Created attachment 453497 [details]
Patch

[youenn fablet]

Ping review.

[Eric Carlson]

Comment on attachment 453497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453497&action=review

> Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:109
> +    auto videoFrame = get(WTFMove(read));

Obviously this isn't new to this patch, but reading this made me realize that RemoteVideoFrameObjectHeap::get is a confusing name because `get` RefPtr::get and Ref::get are so widely used in WebKit and don't mean the same thing at all.

> Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:248
> +            m_videoFrameObjectHeap->get(WTFMove(std::get<RemoteVideoFrameReadReference>(sharedVideoFrame.buffer)));

Ditto.

[youenn fablet]

Created attachment 453718 [details]
Patch for landing

[EWS]

Committed r290824 (248060@main): <https://commits.webkit.org/248060@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453718 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89802729>