237258 – Omit template parameter for SetForScope<> variables

Bug 237258 - Omit template parameter for SetForScope<> variables

Summary: Omit template parameter for SetForScope<> variables

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebCore Misc. (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Chris Dumez

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2022-02-27 12:24 PST by Chris Dumez
Modified:	2022-02-28 11:13 PST (History)
CC List:	15 users (show)

See Also:	237071

Attachments
Patch (135.30 KB, patch) 2022-02-27 12:29 PST, Chris Dumez	no flags	Details \| Formatted Diff \| Diff
[fast-cq] Patch (26.00 KB, patch) 2022-02-28 10:44 PST, Devin Rousso	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Chris Dumez 2022-02-27 12:24:25 PST

Omit template parameter for SetForScope<> variables now that it is no longer required.

Comment 1 Chris Dumez 2022-02-27 12:29:45 PST

Created attachment 453352 [details]
Patch

Comment 2 Darin Adler 2022-02-27 13:05:42 PST

Comment on attachment 453352 [details]
Patch

r=mews

Comment 3 EWS 2022-02-27 17:25:13 PST

Tools/Scripts/svn-apply failed to apply attachment 453352 [details] to trunk.
Please resolve the conflicts and upload a new patch.

Comment 4 Chris Dumez 2022-02-27 17:25:42 PST

<https://commits.webkit.org/r290575>

Comment 5 Radar WebKit Bug Importer 2022-02-27 17:26:16 PST

<rdar://problem/89534796>

Comment 6 Devin Rousso 2022-02-28 10:44:22 PST Comment hidden (obsolete)

Reopening to attach new patch.

Comment 7 Devin Rousso 2022-02-28 10:44:25 PST Comment hidden (obsolete)

Created attachment 453409 [details]
[fast-cq] Patch

Comment 8 Devin Rousso 2022-02-28 10:46:13 PST Comment hidden (obsolete)

Comment on attachment 453409 [details]
[fast-cq] Patch

oops sorry dunno why `webkit-patch` uploaded this here 😅

Comment 9 EWS Watchlist 2022-02-28 10:46:33 PST Comment hidden (obsolete)

This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.

Comment 10 Michael Catanzaro 2022-02-28 11:01:37 PST

Honestly it kinda looks like this makes it harder to read the code, not easier.

Comment 11 Darin Adler 2022-02-28 11:13:13 PST

You’re certainly welcome to your opinion, and no surprise it’s different from mine, but plain old assignment statements also don’t state the type of the value being assigned.