RESOLVED FIXED237258
Omit template parameter for SetForScope<> variables 
https://bugs.webkit.org/show_bug.cgi?id=237258
Summary Omit template parameter for SetForScope<> variables
Chris Dumez
Reported 2022-02-27 12:24:25 PST
Omit template parameter for SetForScope<> variables now that it is no longer required.
Attachments
Patch (135.30 KB, patch)
2022-02-27 12:29 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch (26.00 KB, patch)
2022-02-28 10:44 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-02-27 12:29:45 PST
Created attachment 453352 [details] Patch
Darin Adler
Comment 2 2022-02-27 13:05:42 PST
Comment on attachment 453352 [details] Patch r=mews
EWS
Comment 3 2022-02-27 17:25:13 PST
Tools/Scripts/svn-apply failed to apply attachment 453352 [details] to trunk. Please resolve the conflicts and upload a new patch.
Chris Dumez
Comment 4 2022-02-27 17:25:42 PST
<https://commits.webkit.org/r290575>
Radar WebKit Bug Importer
Comment 5 2022-02-27 17:26:16 PST
<rdar://problem/89534796>
Devin Rousso
Comment 6 2022-02-28 10:44:22 PST Comment hidden (obsolete)
Devin Rousso
Comment 7 2022-02-28 10:44:25 PST Comment hidden (obsolete)
Devin Rousso
Comment 8 2022-02-28 10:46:13 PST Comment hidden (obsolete)
EWS Watchlist
Comment 9 2022-02-28 10:46:33 PST Comment hidden (obsolete)
Michael Catanzaro
Comment 10 2022-02-28 11:01:37 PST
Honestly it kinda looks like this makes it harder to read the code, not easier.
Darin Adler
Comment 11 2022-02-28 11:13:13 PST
You’re certainly welcome to your opinion, and no surprise it’s different from mine, but plain old assignment statements also don’t state the type of the value being assigned.
Note You need to log in before you can comment on or make changes to this bug.