RESOLVED FIXED237231
Drop Ref<>'s operator==() as it is a bit ambiguous / confusing 
https://bugs.webkit.org/show_bug.cgi?id=237231
Summary Drop Ref<>'s operator==() as it is a bit ambiguous / confusing
Chris Dumez
Reported 2022-02-25 16:16:21 PST
Drop Ref<>'s operator==() as it is a bit ambiguous / confusing. Some people expect it to compare pointers while other expect it to compare the values we hold references to. It seems best to omit this operator and be explicit at call sites.
Attachments
Patch (14.52 KB, patch)
2022-02-25 16:49 PST, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (16.14 KB, patch)
2022-02-25 16:59 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-02-25 16:49:45 PST
Created attachment 453276 [details] Patch
Chris Dumez
Comment 2 2022-02-25 16:59:19 PST
Created attachment 453277 [details] Patch
EWS
Comment 3 2022-02-26 15:38:09 PST
Committed r290552 (247830@main): <https://commits.webkit.org/247830@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453277 [details].
Radar WebKit Bug Importer
Comment 4 2022-02-26 15:39:19 PST
<rdar://problem/89518176>
Note You need to log in before you can comment on or make changes to this bug.