Bug 237231 - Drop Ref<>'s operator==() as it is a bit ambiguous / confusing
Summary: Drop Ref<>'s operator==() as it is a bit ambiguous / confusing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-25 16:16 PST by Chris Dumez
Modified: 2022-02-26 15:39 PST (History)
22 users (show)

See Also:

Attachments
Patch (14.52 KB, patch)
2022-02-25 16:49 PST, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (16.14 KB, patch)
2022-02-25 16:59 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-02-25 16:16:21 PST 
Drop Ref<>'s operator==() as it is a bit ambiguous / confusing. Some people expect it to compare pointers while other expect it to compare the values we hold references to.
It seems best to omit this operator and be explicit at call sites.
Comment 1 Chris Dumez 2022-02-25 16:49:45 PST 
Created attachment 453276 [details]
Patch
Comment 2 Chris Dumez 2022-02-25 16:59:19 PST 
Created attachment 453277 [details]
Patch
Comment 3 EWS 2022-02-26 15:38:09 PST 
Committed r290552 (247830@main): <https://commits.webkit.org/247830@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453277 [details].
Comment 4 Radar WebKit Bug Importer 2022-02-26 15:39:19 PST 
<rdar://problem/89518176>