REOPENED 237227
[iOS] Hard link AVPictureInPictureController 
https://bugs.webkit.org/show_bug.cgi?id=237227
Summary [iOS] Hard link AVPictureInPictureController
Per Arne Vollan
Reported 2022-02-25 14:23:32 PST
Weak linking instead of soft linking should be a small performance improvement.
Attachments
Patch (4.87 KB, patch)
2022-02-25 14:23 PST, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.93 KB, patch)
2022-02-25 15:13 PST, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.93 KB, patch)
2022-02-28 07:33 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (4.92 KB, patch)
2022-02-28 09:04 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (5.08 KB, patch)
2022-03-01 12:55 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (6.22 KB, patch)
2022-03-02 10:07 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (6.12 KB, patch)
2022-03-02 10:11 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (6.21 KB, patch)
2022-03-02 11:31 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (6.34 KB, patch)
2022-03-04 07:03 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
expectations (2.63 KB, patch)
2022-03-08 16:55 PST, Dawn Morningstar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2022-02-25 14:23:57 PST
Created attachment 453263 [details] Patch
Per Arne Vollan
Comment 2 2022-02-25 15:13:54 PST
Created attachment 453269 [details] Patch
Per Arne Vollan
Comment 3 2022-02-28 07:33:04 PST
Created attachment 453391 [details] Patch
Per Arne Vollan
Comment 4 2022-02-28 09:00:55 PST
<rdar://76011860>
Per Arne Vollan
Comment 5 2022-02-28 09:04:57 PST
Created attachment 453395 [details] Patch
Brent Fulgham
Comment 6 2022-02-28 09:09:33 PST
Comment on attachment 453395 [details] Patch Seems reasonable.
Per Arne Vollan
Comment 7 2022-02-28 14:57:35 PST
Comment on attachment 453395 [details] Patch Thanks for reviewing!
EWS
Comment 8 2022-02-28 15:49:11 PST
Committed r290619 (247892@main): <https://commits.webkit.org/247892@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453395 [details].
WebKit Commit Bot
Comment 9 2022-03-01 11:32:12 PST
Re-opened since this is blocked by bug 237337
Per Arne Vollan
Comment 10 2022-03-01 12:55:09 PST
Created attachment 453526 [details] Patch
Per Arne Vollan
Comment 11 2022-03-02 10:07:31 PST
Created attachment 453631 [details] Patch
Per Arne Vollan
Comment 12 2022-03-02 10:11:33 PST
Created attachment 453632 [details] Patch
Per Arne Vollan
Comment 13 2022-03-02 11:31:53 PST
Created attachment 453642 [details] Patch
Brent Fulgham
Comment 14 2022-03-02 11:34:19 PST
Comment on attachment 453642 [details] Patch r=me
Per Arne Vollan
Comment 15 2022-03-02 12:36:15 PST
Comment on attachment 453642 [details] Patch Thanks for reviewing!
EWS
Comment 16 2022-03-02 13:12:02 PST
Committed r290752 (247996@main): <https://commits.webkit.org/247996@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453642 [details].
Robert Jenner
Comment 17 2022-03-03 15:46:45 PST
Reverted r290752 for reason: r290752 broke mutliple tests, slowing down the iOS15 EWS queue. Committed r290798 (248038@trunk): <https://commits.webkit.org/248038@trunk>
Per Arne Vollan
Comment 18 2022-03-04 07:03:58 PST
Created attachment 453838 [details] Patch
EWS
Comment 19 2022-03-04 09:46:07 PST
Committed r290835 (248071@main): <https://commits.webkit.org/248071@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453838 [details].
Dawn Morningstar
Comment 20 2022-03-08 14:43:34 PST
(In reply to EWS from comment #19) > Committed r290835 (248071@main): <https://commits.webkit.org/248071@main> > > All reviewed patches have been landed. Closing bug and clearing flags on > attachment 453838 [details]. This commit appears to have caused multiple test failures and is slowing down EWS.
Dawn Morningstar
Comment 21 2022-03-08 15:31:59 PST
Going to set expectations until bug is resolved to avoid a revert loop.
Per Arne Vollan
Comment 22 2022-03-08 15:45:15 PST
(In reply to Matteo Flores from comment #21) > Going to set expectations until bug is resolved to avoid a revert loop. Thanks for catching! What tests are failing?
Dawn Morningstar
Comment 23 2022-03-08 16:55:08 PST
Created attachment 454174 [details] expectations
Dawn Morningstar
Comment 24 2022-03-08 17:03:03 PST
(In reply to Per Arne Vollan from comment #22) > (In reply to Matteo Flores from comment #21) > > Going to set expectations until bug is resolved to avoid a revert loop. > > Thanks for catching! What tests are failing? Sorry for the late reply spent the last little while fiddling with my account for my first commit with committer status! Here's the list: media/picture-in-picture/picture-in-picture-api-css-selector.html, media/picture-in-picture/picture-in-picture-api-enter-pip-1.html, media/picture-in-picture/picture-in-picture-api-enter-pip-2.html, media/picture-in-picture/picture-in-picture-api-enter-pip-3.html, media/picture-in-picture/picture-in-picture-api-enter-pip-4.html, media/picture-in-picture/picture-in-picture-api-events.html, media/picture-in-picture/picture-in-picture-api-exit-pip-1.html, media/picture-in-picture/picture-in-picture-api-pip-window.html, media/picture-in-picture/picture-in-picture-window-aspect-ratio.html, platform/ipad/media/modern-media-controls/pip-support/pip-support-enabled.html
Dawn Morningstar
Comment 25 2022-03-09 10:40:37 PST
Comment on attachment 454174 [details] expectations Clearing flags on attachment: 454174 Committed r291055 (?): <https://commits.webkit.org/r291055>
Dawn Morningstar
Comment 26 2022-03-09 10:40:41 PST
All reviewed patches have been landed. Closing bug.
Dawn Morningstar
Comment 27 2022-03-09 12:38:47 PST
Bug was auto-closed after expectations.
Alexey Proskuryakov
Comment 28 2022-03-18 17:22:31 PDT
> Committed r291055 (?): <https://commits.webkit.org/r291055> The patch was reverted again, but looks like the expectations still need to be reverted.
Note You need to log in before you can comment on or make changes to this bug.