Weak linking instead of soft linking should be a small performance improvement.
Created attachment 453263 [details] Patch
Created attachment 453269 [details] Patch
Created attachment 453391 [details] Patch
<rdar://76011860>
Created attachment 453395 [details] Patch
Comment on attachment 453395 [details] Patch Seems reasonable.
Comment on attachment 453395 [details] Patch Thanks for reviewing!
Committed r290619 (247892@main): <https://commits.webkit.org/247892@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453395 [details].
Re-opened since this is blocked by bug 237337
Created attachment 453526 [details] Patch
Created attachment 453631 [details] Patch
Created attachment 453632 [details] Patch
Created attachment 453642 [details] Patch
Comment on attachment 453642 [details] Patch r=me
Comment on attachment 453642 [details] Patch Thanks for reviewing!
Committed r290752 (247996@main): <https://commits.webkit.org/247996@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453642 [details].
Reverted r290752 for reason: r290752 broke mutliple tests, slowing down the iOS15 EWS queue. Committed r290798 (248038@trunk): <https://commits.webkit.org/248038@trunk>
Created attachment 453838 [details] Patch
Committed r290835 (248071@main): <https://commits.webkit.org/248071@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453838 [details].
(In reply to EWS from comment #19) > Committed r290835 (248071@main): <https://commits.webkit.org/248071@main> > > All reviewed patches have been landed. Closing bug and clearing flags on > attachment 453838 [details]. This commit appears to have caused multiple test failures and is slowing down EWS.
Going to set expectations until bug is resolved to avoid a revert loop.
(In reply to Matteo Flores from comment #21) > Going to set expectations until bug is resolved to avoid a revert loop. Thanks for catching! What tests are failing?
Created attachment 454174 [details] expectations
(In reply to Per Arne Vollan from comment #22) > (In reply to Matteo Flores from comment #21) > > Going to set expectations until bug is resolved to avoid a revert loop. > > Thanks for catching! What tests are failing? Sorry for the late reply spent the last little while fiddling with my account for my first commit with committer status! Here's the list: media/picture-in-picture/picture-in-picture-api-css-selector.html, media/picture-in-picture/picture-in-picture-api-enter-pip-1.html, media/picture-in-picture/picture-in-picture-api-enter-pip-2.html, media/picture-in-picture/picture-in-picture-api-enter-pip-3.html, media/picture-in-picture/picture-in-picture-api-enter-pip-4.html, media/picture-in-picture/picture-in-picture-api-events.html, media/picture-in-picture/picture-in-picture-api-exit-pip-1.html, media/picture-in-picture/picture-in-picture-api-pip-window.html, media/picture-in-picture/picture-in-picture-window-aspect-ratio.html, platform/ipad/media/modern-media-controls/pip-support/pip-support-enabled.html
Comment on attachment 454174 [details] expectations Clearing flags on attachment: 454174 Committed r291055 (?): <https://commits.webkit.org/r291055>
All reviewed patches have been landed. Closing bug.
Bug was auto-closed after expectations.
> Committed r291055 (?): <https://commits.webkit.org/r291055> The patch was reverted again, but looks like the expectations still need to be reverted.