Bug 237198 – RemoteVideoFrameObjectHeap should process its IPC messages in a background thread

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

RemoteVideoFrameObjectHeap should process its IPC messages in a background thread

[youenn fablet]

Created attachment 453196 [details]
Patch

[Darin Adler]

Comment on attachment 453196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453196&action=review

> Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:47
> +    static auto& queue = WorkQueue::create("org.webkit.RemoteVideoFrameObjectHeap", WorkQueue::QOS::UserInteractive).leakRef();
> +    return queue;

In newer code we’ve been using NeverDestroyed rather than leakRef for cases like this. More like this:

    static NeverDestroyed queue = WorkQueue::create("org.webkit.RemoteVideoFrameObjectHeap", WorkQueue::QOS::UserInteractive;
    return queue;

Should be the same generated code.

[youenn fablet]

Created attachment 453343 [details]
Patch for landing

[youenn fablet]

Created attachment 453369 [details]
Patch for landing

[EWS]

Committed r290591 (247869@main): <https://commits.webkit.org/247869@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453369 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89548682>