Bug 237179 - [libpas] Suppress cast-align warnings
Summary: [libpas] Suppress cast-align warnings
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
Keywords: InRadar
Depends on:
Reported: 2022-02-24 20:21 PST by Basuke Suzuki
Modified: 2022-02-25 20:00 PST (History)
9 users (show)

See Also:

PATCH (24.79 KB, patch)
2022-02-25 14:23 PST, Basuke Suzuki
no flags Details | Formatted Diff | Diff
PATCH (1.87 KB, patch)
2022-02-25 17:20 PST, Basuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2022-02-24 20:21:02 PST
There are  tons of cast-align warnings while compiling libpas.
Comment 1 Basuke Suzuki 2022-02-24 20:22:58 PST
Initially I've added -Wno-cast-align compiler flags on bmalloc build, but the headers are also indirectly used in WTF. Disabling that warning in entire WTF doesn't seems a good idea.
Comment 2 Radar WebKit Bug Importer 2022-02-25 09:58:05 PST
Comment 3 Basuke Suzuki 2022-02-25 14:23:52 PST
Created attachment 453262 [details]
Comment 4 Basuke Suzuki 2022-02-25 15:15:33 PST
This patch works, but it's too busy to put the macro into every occurrence. I think it's okay to put the macro to wrap entire code except the one in the macro usage. I believe libpas is carefully written for the situation this warning describes.
Comment 5 Basuke Suzuki 2022-02-25 17:20:54 PST
Created attachment 453280 [details]
Comment 6 Basuke Suzuki 2022-02-25 17:22:00 PST
After discussing with Yusuke, I've decided to follow the treatment of `missing-field-initializers` warning.
Comment 7 Yusuke Suzuki 2022-02-25 17:40:53 PST
Comment on attachment 453280 [details]

Comment 8 EWS 2022-02-25 20:00:46 PST
Committed r290541 (247819@main): <https://commits.webkit.org/247819@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453280 [details].