Bug 237168 - Change one-shot maxTimerNestingLevel from 5 to 10
Summary: Change one-shot maxTimerNestingLevel from 5 to 10
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-24 16:28 PST by Yusuke Suzuki
Modified: 2022-04-01 16:57 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2022-02-24 16:32 PST, Yusuke Suzuki 		sam: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (8.57 KB, patch)
2022-03-31 16:49 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.47 KB, patch)
2022-04-01 11:45 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-02-24 16:28:54 PST 
Change maxTimerNestingLevel from 5 to 10
Comment 1 Yusuke Suzuki 2022-02-24 16:32:24 PST 
Created attachment 453155 [details]
Patch
Comment 2 Sam Weinig 2022-02-28 08:22:49 PST 
Comment on attachment 453155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453155&action=review

> Source/WebCore/ChangeLog:10
> +
> +        Recently, we found from Chromium change[1] that changing this from 5 to 10 offers 10% Speedometer2 improvement
> +        because Speedometer2's setTimeout nesting level is typically 7-8. We discussed with folks including Chris, Maciej,
> +        Saam, and Cameron and now we increase this from 5 to 10 to align to Blink's change to keep these kind of web content fast.

Does the HTML spec say anything here? Perhaps it should? Probably at least worth filing an issue.
Comment 3 Radar WebKit Bug Importer 2022-03-03 16:29:16 PST 
<rdar://problem/89784131>
Comment 4 Yusuke Suzuki 2022-03-31 16:49:09 PDT 
Created attachment 456295 [details]
Patch
Comment 5 Yusuke Suzuki 2022-04-01 11:45:42 PDT 
Created attachment 456380 [details]
Patch
Comment 6 Yusuke Suzuki 2022-04-01 15:19:10 PDT 
mac-wk1 and mac-wk2 bots are getting stuck.
Comment 7 Yusuke Suzuki 2022-04-01 16:57:50 PDT 
Committed r292242 (249140@trunk): <https://commits.webkit.org/249140@trunk>