WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
237156
Take down shared worker context connection less aggressively when it becomes idle
https://bugs.webkit.org/show_bug.cgi?id=237156
Summary
Take down shared worker context connection less aggressively when it becomes ...
Chris Dumez
Reported
2022-02-24 13:33:42 PST
Take down shared worker context connection less aggressively when it becomes idle. Give it 5 seconds before shutting it down in case it ends up being used again in the near future. This is similar to what we do for service workers.
Attachments
Patch
(8.58 KB, patch)
2022-02-24 13:36 PST
,
Chris Dumez
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2022-02-24 13:36:02 PST
Created
attachment 453135
[details]
Patch
Darin Adler
Comment 2
2022-02-24 16:50:06 PST
Comment on
attachment 453135
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=453135&action=review
> Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp:146 > + // Terminate context connection after a little while if it is no longer used by any SharedWorker objects.
If I was doing this change, I’d put this comment on the constant rather than the code that uses it. Not sure that’s better, though.
Chris Dumez
Comment 3
2022-02-24 16:54:11 PST
Committed
r290477
(
247775@trunk
): <
https://commits.webkit.org/247775@trunk
>
Radar WebKit Bug Importer
Comment 4
2022-02-24 16:55:18 PST
<
rdar://problem/89447191
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug