RESOLVED FIXED 237151
[iOS] Add support for replacing WKFoundTextRanges 
https://bugs.webkit.org/show_bug.cgi?id=237151
Summary [iOS] Add support for replacing WKFoundTextRanges
Aditya Keerthi
Reported 2022-02-24 12:18:56 PST
...
Attachments
Patch (12.50 KB, patch)
2022-02-24 12:26 PST, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2022-02-24 12:19:13 PST
rdar://89258687
Aditya Keerthi
Comment 2 2022-02-24 12:26:14 PST
Created attachment 453124 [details] Patch
Wenson Hsieh
Comment 3 2022-02-24 13:01:53 PST
Comment on attachment 453124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453124&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10432 > + return self.webView._editable; It's a tiny bit surprising that this is only for Mail compose. I suppose that's because there's no per-text-range notion of editability baked into the API yet?
Aditya Keerthi
Comment 4 2022-02-24 16:57:36 PST
(In reply to Wenson Hsieh from comment #3) > Comment on attachment 453124 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453124&action=review > > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10432 > > + return self.webView._editable; > > It's a tiny bit surprising that this is only for Mail compose. I suppose > that's because there's no per-text-range notion of editability baked into > the API yet? Thanks for the review! Per-text-range editability is still under discussion (there is partial support). This patch addresses the simpler, higher value replacement scenario.
EWS
Comment 5 2022-02-24 17:44:13 PST
Committed r290481 (247777@main): <https://commits.webkit.org/247777@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453124 [details].
Note You need to log in before you can comment on or make changes to this bug.