Bug 237151 - [iOS] Add support for replacing WKFoundTextRanges
Summary: [iOS] Add support for replacing WKFoundTextRanges
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-24 12:18 PST by Aditya Keerthi
Modified: 2022-02-24 17:44 PST (History)
6 users (show)

See Also:


Attachments
Patch (12.50 KB, patch)
2022-02-24 12:26 PST, Aditya Keerthi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2022-02-24 12:18:56 PST
...
Comment 1 Aditya Keerthi 2022-02-24 12:19:13 PST
rdar://89258687
Comment 2 Aditya Keerthi 2022-02-24 12:26:14 PST
Created attachment 453124 [details]
Patch
Comment 3 Wenson Hsieh 2022-02-24 13:01:53 PST
Comment on attachment 453124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453124&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10432
> +    return self.webView._editable;

It's a tiny bit surprising that this is only for Mail compose. I suppose that's because there's no per-text-range notion of editability baked into the API yet?
Comment 4 Aditya Keerthi 2022-02-24 16:57:36 PST
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 453124 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=453124&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10432
> > +    return self.webView._editable;
> 
> It's a tiny bit surprising that this is only for Mail compose. I suppose
> that's because there's no per-text-range notion of editability baked into
> the API yet?

Thanks for the review!

Per-text-range editability is still under discussion (there is partial support). This patch addresses the simpler, higher value replacement scenario.
Comment 5 EWS 2022-02-24 17:44:13 PST
Committed r290481 (247777@main): <https://commits.webkit.org/247777@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453124 [details].