RESOLVED CONFIGURATION CHANGED23714
void CSSStyleDeclaration::diff(CSSMutableStyleDeclaration* style) const is poorly named and backwards! 
https://bugs.webkit.org/show_bug.cgi?id=23714
Summary void CSSStyleDeclaration::diff(CSSMutableStyleDeclaration* style) const is po...
Eric Seidel (no email)
Reported 2009-02-03 14:29:21 PST
void CSSStyleDeclaration::diff(CSSMutableStyleDeclaration* style) const is poorly named and backwards! It really should be something like "removePropertiesMatching(CSSMutableStyleDeclaration*)" or similar. I ran across this while trying to fix font-decoration toggling execCommands.
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2022-07-22 10:09:38 PDT
CSSMutableStyleDeclaration - only has one hit in Webkit source code on Github and it is in unit test python file and I think this bug was fixed some time back and renamed. https://github.com/WebKit/WebKit/blob/8afe31a018b11741abdf9b4d5bb973d7c1d9ff05/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py#L296 I think this can be closed now. Thanks!
Alexey Proskuryakov
Comment 2 2022-07-22 15:03:10 PDT
This is about CSSStyleDeclaration::diff, not about CSSMutableStyleDeclaration. But either way, there isn't such function any more.
Note You need to log in before you can comment on or make changes to this bug.