Bug 237134 - RemoteCaptureSampleManager, UserMediaSampleCaptureManagerProxy create the RemoteVideoFrame incorrectly
Summary: RemoteCaptureSampleManager, UserMediaSampleCaptureManagerProxy create the Rem...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-24 02:59 PST by Kimmo Kinnunen
Modified: 2022-02-26 23:30 PST (History)
8 users (show)

See Also:

Attachments
Patch (11.84 KB, patch)
2022-02-24 03:12 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for landing (11.86 KB, patch)
2022-02-25 05:17 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for landing (11.84 KB, patch)
2022-02-25 05:23 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for landing (11.71 KB, patch)
2022-02-26 07:06 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-02-24 02:59:40 PST 
RemoteCaptureSampleManager, UserMediaSampleCaptureManagerProxy create the RemoteVideoFrame in incorrectly
Comment 1 Kimmo Kinnunen 2022-02-24 03:12:42 PST 
Created attachment 453088 [details]
Patch
Comment 2 youenn fablet 2022-02-24 05:36:37 PST 
Comment on attachment 453088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453088&action=review

> Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:207
> +            m_connection->send(Messages::RemoteCaptureSampleManager::VideoSampleAvailable(m_id, WTFMove(properties), metadata), 0);

No need for WTFMove.

> Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:213
> +        m_connection->send(Messages::RemoteCaptureSampleManager::VideoSampleAvailableCV(m_id, WTFMove(*remoteSample), metadata), 0);

No need for WTFMove.
Comment 3 Kimmo Kinnunen 2022-02-25 05:17:33 PST 
Created attachment 453203 [details]
Patch for landing
Comment 4 Kimmo Kinnunen 2022-02-25 05:23:47 PST 
Created attachment 453204 [details]
Patch for landing
Comment 5 EWS 2022-02-26 00:47:48 PST 
Tools/Scripts/svn-apply failed to apply attachment 453204 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 6 Kimmo Kinnunen 2022-02-26 07:06:32 PST 
Created attachment 453295 [details]
Patch for landing
Comment 7 EWS 2022-02-26 23:29:03 PST 
Committed r290555 (247833@main): <https://commits.webkit.org/247833@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453295 [details].
Comment 8 Radar WebKit Bug Importer 2022-02-26 23:30:21 PST 
<rdar://problem/89522455>