Bug 237124 - [GTK] Unreviewed, fix build after r290399
Summary: [GTK] Unreviewed, fix build after r290399
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-23 17:29 PST by Diego Pino
Modified: 2022-02-23 17:35 PST (History)
0 users

See Also:

Attachments
[fast-cq] Patch (1.62 KB, patch)
2022-02-23 17:31 PST, Diego Pino 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2022-02-23 17:29:40 PST 
[GTK] Unreviewed, fix build after r290399
Comment 1 Diego Pino 2022-02-23 17:31:40 PST 
Created attachment 453057 [details]
[fast-cq] Patch
Comment 2 Diego Pino 2022-02-23 17:35:12 PST 
STDIO: https://build.webkit.org/#/builders/41/builds/9656/steps/9/logs/stdio

/app/webkit/Source/WebCore/page/DOMWindow.cpp: In member function ‘void WebCore::DOMWindow::showModalDialog(const WTF::String&, const WTF::String&, WebCore::DOMWindow&, WebCore::DOMWindow&, const WTF::Function<void(WebCore::DOMWindow&)>&)’:
/app/webkit/Source/WebCore/page/DOMWindow.cpp:2672:5: error: ‘printWarningMessage’ was not declared in this scope; did you mean ‘printErrorMessage’?
 2672 |     printWarningMessage("showModalDialog() is deprecated and will be removed. Please use the <dialog> element instead."_s);
      |     ^~~~~~~~~~~~~~~~~~~
      |     printErrorMessage
Comment 3 Diego Pino 2022-02-23 17:35:43 PST 
Fixed by https://trac.webkit.org/changeset/290406/webkit