Bug 237099 - Adopt more widely the new URL constructor that takes in a String
Summary: Adopt more widely the new URL constructor that takes in a String
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 237068
Blocks:
  Show dependency tree / graph
 
Reported: 2022-02-23 11:50 PST by Chris Dumez
Modified: 2022-02-23 15:20 PST (History)
6 users (show)

See Also:

Attachments
Patch (167.98 KB, patch)
2022-02-23 11:57 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (170.42 KB, patch)
2022-02-23 14:34 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-02-23 11:50:51 PST 
Adopt more widely the new URL constructor that takes in a String.
Comment 1 Chris Dumez 2022-02-23 11:57:15 PST 
Created attachment 453008 [details]
Patch
Comment 2 Darin Adler 2022-02-23 13:56:25 PST 
Comment on attachment 453008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453008&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:881
> -    URL url(URL(), uriString);
> +    URL url { uriString };
>      return url;

I would have merged these into one line.

> Source/WebCore/platform/win/PasteboardWin.cpp:614
> +        URL kurl { url };

"kurl", ha ha ha
Comment 3 Chris Dumez 2022-02-23 14:34:18 PST 
Created attachment 453029 [details]
Patch
Comment 4 EWS 2022-02-23 15:19:46 PST 
Committed r290394 (247708@main): <https://commits.webkit.org/247708@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453029 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-23 15:20:26 PST 
<rdar://problem/89381477>