Modify our preference observation code to also provide notifications for changes to preferences stored as the currentHost.
Created attachment 453007 [details] Patch
Comment on attachment 453007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453007&action=review > Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm:76 > + auto hostValue = adoptCF(CFPreferencesCopyValue((__bridge CFStringRef)key, kCFPreferencesAnyApplication, kCFPreferencesCurrentUser, kCFPreferencesCurrentHost)); If CurrentHost and AnyHost are treated the same on iOS, should we conditionalize this on PLATFORM(MAC), or maybe !PLATFORM(IOS)?
Comment on attachment 453007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453007&action=review r=me >> Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm:76 >> + auto hostValue = adoptCF(CFPreferencesCopyValue((__bridge CFStringRef)key, kCFPreferencesAnyApplication, kCFPreferencesCurrentUser, kCFPreferencesCurrentHost)); > > If CurrentHost and AnyHost are treated the same on iOS, should we conditionalize this on PLATFORM(MAC), or maybe !PLATFORM(IOS)? I talked with Gavin offline, and we actually do want it to work this way on all platforms.
<rdar://problem/89373662>
Created attachment 453102 [details] Patch
Created attachment 453105 [details] Patch
Comment on attachment 453105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453105&action=review r=me > Source/WebKit/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=237098 <rdar://problem/89373662> Please always include the Radar in Changelogs, as it makes it easier to find things using the Xcode change viewer. > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:748 > +#if PLATFORM(COCOA) Oops -- yes, this would never have worked properly for macOS!
Committed r290482 (247778@main): <https://commits.webkit.org/247778@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453105 [details].