Bug 237095 - [ Mac EWS ] imported/w3c/web-platform-tests/workers/semantics/multiple-workers/004.html is a flaky text failure
Summary: [ Mac EWS ] imported/w3c/web-platform-tests/workers/semantics/multiple-worker...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
Keywords: InRadar
: 241957 (view as bug list)
Depends on:
Reported: 2022-02-23 11:21 PST by Robert Jenner
Modified: 2022-07-08 03:03 PDT (History)
5 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2022-02-23 11:21:59 PST

is a flaky text failure on macOS, and is affecting EWS as well.



-PASS shared worker with multiple documents
+Harness Error (TIMEOUT), message = null
+NOTRUN shared worker with multiple documents

Comment 1 Radar WebKit Bug Importer 2022-02-23 11:22:25 PST
Comment 2 Robert Jenner 2022-02-23 11:29:18 PST
Added [ Pass Failure ] expectation here to speed up EWS:

Comment 3 Robert Jenner 2022-02-23 12:18:37 PST
I did attempt to reproduce this failure at Monterey Production ToT. However, I was unsuccessful. I even took it all the way up to 1000 iterations.
Comment 4 Chris Dumez 2022-02-24 09:49:03 PST
I added some logging in <https://commits.webkit.org/r290439> to help investigate via the bots since I wasn't able to reproduce locally yet.
Comment 5 youenn fablet 2022-06-20 05:03:59 PDT
Added logging shows the following:
CONSOLE MESSAGE: Error: assert_equals: Worker Message Count expected 3 but got 0

Iframes are being loaded but one of the following hypothesis is probably true:
- shared worker might not being executed
- shared worker might not be receiving the connect event
- MessagePort postMessage sometimes does not work
Comment 6 youenn fablet 2022-06-22 04:59:08 PDT
One possibility is that we delay the connect event until we have a process to run the shared worker.
We then fire the connect event for all SharedWorker but we do not respect the order so the first port is related to the iframe SharedWorker instead of the main frame SharedWorker.
Comment 7 youenn fablet 2022-06-22 09:32:35 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1684
Comment 8 EWS 2022-06-23 05:44:08 PDT
Committed r295776 (251781@main): <https://commits.webkit.org/251781@main>

Reviewed commits have been landed. Closing PR #1684 and removing active labels.
Comment 10 youenn fablet 2022-06-24 00:37:19 PDT
Added test is also flaky (fix available at https://bugs.webkit.org/show_bug.cgi?id=241957).
Given I will not be able to fix it very soon, let's revert this change for now in https://bugs.webkit.org/show_bug.cgi?id=241958.
Comment 11 youenn fablet 2022-06-24 00:39:17 PDT
Reopening to fix the debug assertion and flaky test
Comment 12 youenn fablet 2022-06-24 00:39:51 PDT
*** Bug 241957 has been marked as a duplicate of this bug. ***
Comment 13 youenn fablet 2022-07-04 05:57:02 PDT
Pull request: https://github.com/WebKit/WebKit/pull/2054
Comment 14 EWS 2022-07-08 03:03:48 PDT
Committed 252267@main (82a9cba78565): <https://commits.webkit.org/252267@main>

Reviewed commits have been landed. Closing PR #2054 and removing active labels.