Bug 237090 - [IFC][Integration] LineLayout::firstLinePhysicalBaseline/lastLineLogicalBaseline should flip box baseline value for vertical-lr
Summary: [IFC][Integration] LineLayout::firstLinePhysicalBaseline/lastLineLogicalBasel...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-23 09:38 PST by zalan
Modified: 2022-02-23 12:54 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.25 KB, patch)
2022-02-23 09:39 PST, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-02-23 09:38:18 PST
ssia
Comment 1 zalan 2022-02-23 09:39:29 PST
Created attachment 452992 [details]
Patch
Comment 2 Antti Koivisto 2022-02-23 09:46:14 PST
Comment on attachment 452992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452992&action=review

> Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:466
> +    switch (rootLayoutBox().style().writingMode()) {
> +    case WritingMode::TopToBottom:

wonder if the switch could be usefully shared between first/last cases?
Comment 3 zalan 2022-02-23 09:53:26 PST
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 452992 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452992&action=review
> 
> > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:466
> > +    switch (rootLayoutBox().style().writingMode()) {
> > +    case WritingMode::TopToBottom:
> 
> wonder if the switch could be usefully shared between first/last cases?

I'd rather not mix logical and physical translates (the first baseline API returns physical while the last baseline API returns logical baseline value)
Comment 4 EWS 2022-02-23 12:35:21 PST
Committed r290388 (247703@main): <https://commits.webkit.org/247703@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452992 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-23 12:36:16 PST
<rdar://problem/89372080>