Bug 23709 - Fix a callsite of Frame::adjustPageHeight in FrameChromium.cpp
Summary: Fix a callsite of Frame::adjustPageHeight in FrameChromium.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Eric Roman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-03 11:58 PST by Eric Roman
Modified: 2009-02-03 20:50 PST (History)
2 users (show)

See Also:

Attachments
Update Frame::adjustPageHeight callsite to FrameView::adjustPageHeight (1.36 KB, patch)
2009-02-03 11:59 PST, Eric Roman 		zecke: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Roman 2009-02-03 11:58:41 PST 
FrameChromium.cpp references Frame::adjustPageHeight, which as of r40473 has been moved to FrameView::adjustPageHeight.
Comment 1 Eric Roman 2009-02-03 11:59:40 PST 
Created attachment 27283 [details]
Update Frame::adjustPageHeight callsite to FrameView::adjustPageHeight
Comment 2 Holger Freyther 2009-02-03 12:51:59 PST 
Comment on attachment 27283 [details]
Update Frame::adjustPageHeight callsite to FrameView::adjustPageHeight

yes, and the view is already null checked.
Comment 3 Holger Freyther 2009-02-03 13:01:29 PST 
Landed in r40545 but why isn't PrintContext::computePageRects used?
Comment 4 Eric Roman 2009-02-03 13:49:55 PST 
Thanks for the review + check-in!

> but why isn't PrintContext::computePageRects used?

That's a good question.

Marc-Antoine: do you know why we have duplicated this code (it is basically the same as page/PrintContext.cpp)?
Comment 5 Marc-Antoine Ruel 2009-02-03 20:50:10 PST 
Simply because it wasn't existing last year and I had to extract the function because it was mixed with code we couldn't use (don't 100% remember). We should remove the duplicate code.