a plugin with non-fixed sized layout, or resized using javascript, never informs the plugin of the new size. attached is a simple html that triggers the issue als attached is a patch that fixes it basically copied some more code from PluginViewMac.cpp
Created attachment 27278 [details] plugin-resize example
Created attachment 27279 [details] inform plugin of window resize
(adding two cc-s from svn praise)
Created attachment 27385 [details] inform plugin of window resize v2 adding manual testcase fixed issue in scrolling plugin window off page, that should also be in original code since that is the reason the removed check was there in the first place
(In reply to comment #4) Hi, there's a few style issues in your patch: - No ChangeLog: you need to generate one using the script ot WebKitTools/Scripts/prepare-ChangeLog. - It seems the patch does at least two more or less unrelated cleanups/fixes, maybe it would be nice to split it... + // sanity check + if (! m_plugin->pluginFuncs()->event) + return false; No space between '!' and m_plugin... void PluginView::setNPWindowRect(const IntRect& rect) { - if (!m_isStarted || !parent()) - return; - - IntPoint p = static_cast<FrameView*>(parent())->contentsToWindow(rect.location()); - m_npWindow.x = p.x(); - m_npWindow.y = p.y(); - - m_npWindow.width = rect.width(); - m_npWindow.height = rect.height(); - - m_npWindow.clipRect.left = 0; - m_npWindow.clipRect.top = 0; - m_npWindow.clipRect.right = rect.width(); - m_npWindow.clipRect.bottom = rect.height(); + setNPWindowIfNeeded(); +} Since this does not use the parameter anymore you should change it to 'const IntRect&', lose the name. - } else if (m_isWindowed) + } else if (m_isWindowed) { setPlatformWidget(gtk_xtbin_new(m_parentFrame->view()->hostWindow()->platformWindow()->window, 0)); + } No braces for one-line control clauses. If you can update it and mark it for review (select '?' in the review combobox when uploading the patch), I'll try to get someone familiar with this to have a look at it. Thanks!
Created attachment 28160 [details] resize patch v3 updated style issues, added ChangeLog Doing the NPEvents in right order is somewhat secondairy issue, but required to event the window correctly too. So still one patch.
Comment on attachment 28160 [details] resize patch v3 r=me
Landed as r41383.