Bug 237062 – PingLoader is failing to call completion handler in error case

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

WebKit is failing to trigger the completion handler when PingLoad handles a redirect that results in an error.

<rdar://50157253>

[Brent Fulgham]

Created attachment 452907 [details]
Patch

[Chris Dumez]

Comment on attachment 452907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452907&action=review

> Source/WebKit/NetworkProcess/PingLoad.cpp:143
> +            completionHandler({ });

Is there a reason we need to call this before the didFinish() call?
Would seem more logical the other way around for me.

[Brent Fulgham]

Comment on attachment 452907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452907&action=review

>> Source/WebKit/NetworkProcess/PingLoad.cpp:143
>> +            completionHandler({ });
> 
> Is there a reason we need to call this before the didFinish() call?
> Would seem more logical the other way around for me.

I just made this call int he same place as the previous error section (immediately above). I'll change it before landing.

[Brent Fulgham]

Created attachment 452908 [details]
Patch for landing

[EWS]

Committed r290338 (247659@main): <https://commits.webkit.org/247659@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452908 [details].

[Darin Adler]

Can we add some tests?