Bug 237043 - [WebAuthn] userHandle not marked nullable in _WKWebAuthenticationAssertionResponse
Summary: [WebAuthn] userHandle not marked nullable in _WKWebAuthenticationAssertionRes...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: pascoe@apple.com
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-22 09:42 PST by pascoe@apple.com
Modified: 2022-02-23 10:21 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.28 KB, patch)
2022-02-22 10:18 PST, pascoe@apple.com
no flags Details | Formatted Diff | Diff
Patch (10.03 KB, patch)
2022-02-22 13:58 PST, pascoe@apple.com
no flags Details | Formatted Diff | Diff
Patch (17.12 KB, patch)
2022-02-22 14:49 PST, pascoe@apple.com
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description pascoe@apple.com 2022-02-22 09:42:27 PST
This is causing issues where the userHandle is actually null. This is allowed by the WebAuthn spec: https://www.w3.org/TR/webauthn-2/#dom-authenticatorassertionresponse-userhandle
Comment 1 pascoe@apple.com 2022-02-22 09:42:44 PST
rdar://89275844
Comment 2 pascoe@apple.com 2022-02-22 10:18:41 PST
Created attachment 452882 [details]
Patch
Comment 3 pascoe@apple.com 2022-02-22 13:58:58 PST
Created attachment 452901 [details]
Patch
Comment 4 pascoe@apple.com 2022-02-22 14:47:57 PST
rdar://89317740
Comment 5 pascoe@apple.com 2022-02-22 14:49:19 PST
Created attachment 452904 [details]
Patch
Comment 6 Brent Fulgham 2022-02-23 10:00:21 PST
Comment on attachment 452904 [details]
Patch

r=me
Comment 7 EWS 2022-02-23 10:21:16 PST
Committed r290381 (247696@main): <https://commits.webkit.org/247696@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452904 [details].