Bug 237042 – fast/mediastream/getUserMedia-to-canvas-1.html and fast/mediastream/getUserMedia-to-canvas-2.html are failing on MacOS when remote video frame flag is enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

See https://ews-build.webkit.org/#/builders/60/builds/24471.
On the bots, this is happening on MacOS with webrtc remote frame turned on and WebGL GPUProcess turned off.

[Radar WebKit Bug Importer]

<rdar://problem/89298601>

[youenn fablet]

Created attachment 453481 [details]
Patch

[Eric Carlson]

Comment on attachment 453481 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453481&action=review

> LayoutTests/ChangeLog:3
> +        fast/mediastream/getUserMedia-to-canvas-1.html and fast/mediastream/getUserMedia-to-canvas-2.html are failing on MacOS when remote video frame flag is enabled

Nit: It would be nice to wrap the very long lines in this ChangeLog so they are easier to read on a small screen

> LayoutTests/ChangeLog:9
> +        Video element videoWidth/videoHeight are updated when track settings are changed, and not according video frames being received.

s/not according video frames being/not when video frames are/

[youenn fablet]

Created attachment 453506 [details]
Patch for landing

[EWS]

Committed r290658 (247930@main): <https://commits.webkit.org/247930@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453506 [details].

[Robert Jenner]

Reverted r290658 for reason:

r290658 broke two tests for iOS, slowing down EWS.

Committed r290763 (248007@trunk): <https://commits.webkit.org/248007@trunk>

[youenn fablet]

Created attachment 453707 [details]
Patch

[EWS]

Committed r290819 (248055@main): <https://commits.webkit.org/248055@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453707 [details].