Bug 237036 - [IFC][Integration] LineLayout::firstInlineBoxRect should flip the rect coordinates for vertical-rl
Summary: [IFC][Integration] LineLayout::firstInlineBoxRect should flip the rect coordi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-22 06:26 PST by zalan
Modified: 2022-02-23 10:29 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2022-02-22 06:39 PST, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (2.34 KB, patch)
2022-02-23 09:20 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-02-22 06:26:59 PST 
ssia
Comment 1 zalan 2022-02-22 06:39:47 PST 
Created attachment 452866 [details]
Patch
Comment 2 Darin Adler 2022-02-22 09:49:39 PST 
Comment on attachment 452866 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452866&action=review

> Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:580
> +        firstBoxRect.setX(flow().width() - firstBoxRect.width() - firstBoxRect.x());

This is better:

    firstBoxRect.setX(flow().width() - firstBoxRect.maxX());

Also, I think we should switch on writingMode rather than using if statements.
Comment 3 zalan 2022-02-23 09:20:35 PST 
Created attachment 452989 [details]
[fast-cq]Patch
Comment 4 EWS 2022-02-23 10:28:06 PST 
Committed r290382 (247697@main): <https://commits.webkit.org/247697@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452989 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-23 10:29:20 PST 
<rdar://problem/89364260>