Bug 237030 – [JSC] Make runner should only schedule tests on live remotes

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Angelos Oikonomopoulos]

[JSC] Make runner should only schedule tests on live remotes

[Angelos Oikonomopoulos]

Created attachment 452851 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/89611629>

[Adrian Perez]

Comment on attachment 452851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452851&action=review

> Tools/Scripts/run-jsc-stress-tests:2584
> +        "sysctl -n hw.activecpu 2>/dev/null || nproc --all 2>/dev/null"

I remember we chatted about using “getconf _NPROCESSORS_ONLN” here as one last
resort option, so you might want to add that before landing. Nevertheless, given
that it's not currently needed for the runners where this has to work, feel free
to land the patch as-is.

[Angelos Oikonomopoulos]

Created attachment 454222 [details]
Patch

[Angelos Oikonomopoulos]

(In reply to Adrian Perez from comment #3)
> Comment on attachment 452851 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452851&action=review
> 
> > Tools/Scripts/run-jsc-stress-tests:2584
> > +        "sysctl -n hw.activecpu 2>/dev/null || nproc --all 2>/dev/null"
> 
> I remember we chatted about using “getconf _NPROCESSORS_ONLN” here as one
> last
> resort option, so you might want to add that before landing. Nevertheless,
> given
> that it's not currently needed for the runners where this has to work, feel
> free
> to land the patch as-is.

Yup. This patch predates our discussion re: getconf. Uploaded a new version that uses it if all else has failed.

[EWS]

Committed r291045 (248219@main): <https://commits.webkit.org/248219@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454222 [details].