Bug 237022 - Thread safety analysis macros are confusing for non-Lock use-cases
Summary: Thread safety analysis macros are confusing for non-Lock use-cases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 236832
  Show dependency tree / graph
 
Reported: 2022-02-22 00:09 PST by Kimmo Kinnunen
Modified: 2022-02-23 02:01 PST (History)
14 users (show)

See Also:

Attachments
Patch (274.59 KB, patch)
2022-02-22 00:37 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Option B without the renames (18.00 KB, patch)
2022-02-22 04:07 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-02-22 00:09:38 PST 
Thread safety analysis macros are confusing for non-Lock use-cases
Comment 1 Kimmo Kinnunen 2022-02-22 00:37:25 PST 
Created attachment 452838 [details]
Patch
Comment 2 Kimmo Kinnunen 2022-02-22 04:07:22 PST 
Created attachment 452855 [details]
Option B without the renames
Comment 3 Chris Dumez 2022-02-22 07:21:44 PST 
Comment on attachment 452855 [details]
Option B without the renames

r=me
Comment 4 Dean Jackson 2022-02-22 09:03:09 PST 
Comment on attachment 452838 [details]
Patch

Removing the r? flag from the first patch.
Comment 5 Jonathan Bedard 2022-02-22 16:44:29 PST 
Stopped https://ews-build.webkit.org/#/builders/70/builds/1025, the 3 failures it flagged are already known.
Comment 6 Jonathan Bedard 2022-02-22 16:47:27 PST 
The 3 failures flagged by https://ews-build.webkit.org/#/builders/70/builds/1025 are already known, so I stopped the build.
Comment 7 EWS 2022-02-23 02:00:25 PST 
Committed r290361 (247679@main): <https://commits.webkit.org/247679@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452855 [details].
Comment 8 Radar WebKit Bug Importer 2022-02-23 02:01:23 PST 
<rdar://problem/89344972>