WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
237022
Thread safety analysis macros are confusing for non-Lock use-cases
https://bugs.webkit.org/show_bug.cgi?id=237022
Summary
Thread safety analysis macros are confusing for non-Lock use-cases
Kimmo Kinnunen
Reported
2022-02-22 00:09:38 PST
Thread safety analysis macros are confusing for non-Lock use-cases
Attachments
Patch
(274.59 KB, patch)
2022-02-22 00:37 PST
,
Kimmo Kinnunen
no flags
Details
Formatted Diff
Diff
Option B without the renames
(18.00 KB, patch)
2022-02-22 04:07 PST
,
Kimmo Kinnunen
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1
2022-02-22 00:37:25 PST
Created
attachment 452838
[details]
Patch
Kimmo Kinnunen
Comment 2
2022-02-22 04:07:22 PST
Created
attachment 452855
[details]
Option B without the renames
Chris Dumez
Comment 3
2022-02-22 07:21:44 PST
Comment on
attachment 452855
[details]
Option B without the renames r=me
Dean Jackson
Comment 4
2022-02-22 09:03:09 PST
Comment on
attachment 452838
[details]
Patch Removing the r? flag from the first patch.
Jonathan Bedard
Comment 5
2022-02-22 16:44:29 PST
Stopped
https://ews-build.webkit.org/#/builders/70/builds/1025
, the 3 failures it flagged are already known.
Jonathan Bedard
Comment 6
2022-02-22 16:47:27 PST
The 3 failures flagged by
https://ews-build.webkit.org/#/builders/70/builds/1025
are already known, so I stopped the build.
EWS
Comment 7
2022-02-23 02:00:25 PST
Committed
r290361
(
247679@main
): <
https://commits.webkit.org/247679@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 452855
[details]
.
Radar WebKit Bug Importer
Comment 8
2022-02-23 02:01:23 PST
<
rdar://problem/89344972
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug