Bug 237021 - http/wpt/mediarecorder/mute-tracks.html fails with WebRTCRemoteVideoFrameEnabled=true
Summary: http/wpt/mediarecorder/mute-tracks.html fails with WebRTCRemoteVideoFrameEnab...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 236969
  Show dependency treegraph
 
Reported: 2022-02-22 00:00 PST by youenn fablet
Modified: 2022-02-22 08:07 PST (History)
9 users (show)

See Also:


Attachments
Patch (5.41 KB, patch)
2022-02-22 00:06 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-02-22 00:00:22 PST
http/wpt/mediarecorder/mute-tracks.html fails with WebRTCRemoteVideoFrameEnabled=true
Comment 1 youenn fablet 2022-02-22 00:06:50 PST
Created attachment 452833 [details]
Patch
Comment 2 Kimmo Kinnunen 2022-02-22 01:27:33 PST
Comment on attachment 452833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452833&action=review

> Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:99
>          // FIXME: We could optimize sending black frames by only sending width/height.

I think it'd be the time to address the fixme. Sending dummy pixels of possibly invalid size..
Comment 3 youenn fablet 2022-02-22 01:38:58 PST
(In reply to Kimmo Kinnunen from comment #2)
> Comment on attachment 452833 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452833&action=review
> 
> > Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:99
> >          // FIXME: We could optimize sending black frames by only sending width/height.
> 
> I think it'd be the time to address the fixme. Sending dummy pixels of
> possibly invalid size..

Yes, I have a local patch that does that through a new SharedVideoFrame that will replace RemoteVideoSample.
As of the size, when the track is muted, the spec is very light on whether we should respect the size of the frame or not. Currently, we stick to using the same size over and over, which is probably the safest option.
Comment 4 EWS 2022-02-22 08:06:55 PST
Committed r290307 (247630@main): <https://commits.webkit.org/247630@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452833 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-22 08:07:30 PST
<rdar://problem/89294409>