Bug 237021 – http/wpt/mediarecorder/mute-tracks.html fails with WebRTCRemoteVideoFrameEnabled=true

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

http/wpt/mediarecorder/mute-tracks.html fails with WebRTCRemoteVideoFrameEnabled=true

[youenn fablet]

Created attachment 452833 [details]
Patch

[Kimmo Kinnunen]

Comment on attachment 452833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452833&action=review

> Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:99
>          // FIXME: We could optimize sending black frames by only sending width/height.

I think it'd be the time to address the fixme. Sending dummy pixels of possibly invalid size..

[youenn fablet]

(In reply to Kimmo Kinnunen from comment #2)
> Comment on attachment 452833 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452833&action=review
> 
> > Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:99
> >          // FIXME: We could optimize sending black frames by only sending width/height.
> 
> I think it'd be the time to address the fixme. Sending dummy pixels of
> possibly invalid size..

Yes, I have a local patch that does that through a new SharedVideoFrame that will replace RemoteVideoSample.
As of the size, when the track is muted, the spec is very light on whether we should respect the size of the frame or not. Currently, we stick to using the same size over and over, which is probably the safest option.

[EWS]

Committed r290307 (247630@main): <https://commits.webkit.org/247630@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452833 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89294409>