Currently, here is an example of the output of --reportTotalPhaseTimes=1: ``` [B3] moveConstants total ms: 64.307583 max ms: 1.703167 [B3] lowerToAir total ms: 151.297782 max ms: 5.426375 [B3] generateToAir total ms: 1623.987166 max ms: 92.826750 [B3] simplifyCFG total ms: 11.760463 max ms: 1.088083 [B3] Air::lowerMacros total ms: 5.975679 max ms: 0.382000 ``` There are two frustrating things here: - The numbers are not aligned, so it is not visible at a glance which passes take 1 order of magnitude more than others - everything is just tagged by [B3] even when they're actually Air, and passes are tagged in the same way as combination of passes (like generateToAir). I propose a simple formatting change that would output it as follows: ``` total ms: 66.328 max ms: 2.283 [B3] moveConstants total ms: 148.097 max ms: 5.361 [B3] lowerToAir total ms: 1619.115 max ms: 96.307 [Total B3] generateToAir total ms: 11.959 max ms: 1.185 [Air] simplifyCFG total ms: 6.519 max ms: 0.697 [Air] Air::lowerMacros ``` I found this a lot more readable when trying to optimize parts of the FTL compiler.
Created attachment 452796 [details] Patch
Created attachment 452798 [details] Patch Fix style nits.
Comment on attachment 452798 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452798&action=review r=me. Nice > Source/WTF/wtf/FixedWidthDouble.h:2 > + * Copyright (C) 2021 Apple Inc. All rights reserved. 2022
Committed r290290 (247614@main): <https://commits.webkit.org/247614@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452798 [details].
<rdar://problem/89277242>