RESOLVED FIXED 236998
NSSharingServicePicker gets deallocated when using the standard share menu item 
https://bugs.webkit.org/show_bug.cgi?id=236998
Summary NSSharingServicePicker gets deallocated when using the standard share menu item
Kate Cheney
Reported 2022-02-21 15:11:55 PST
NSSharingServicePicker gets deallocated when using the standard share menu item
Attachments
Patch (1.69 KB, patch)
2022-02-21 15:12 PST, Kate Cheney 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2022-02-21 15:12:58 PST
Created attachment 452782 [details] Patch
Kate Cheney
Comment 2 2022-02-21 15:13:24 PST
rdar://89174827
Wenson Hsieh
Comment 3 2022-02-21 15:43:44 PST
Comment on attachment 452782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452782&action=review > Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:419 > + [shareMenuItem setRepresentedObject:sharingServicePicker.get()]; Do we need to also unset this at some point in time? (Or does it clean up when the menu is done presenting?)
Kate Cheney
Comment 4 2022-02-21 16:04:09 PST
(In reply to Wenson Hsieh from comment #3) > Comment on attachment 452782 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452782&action=review > > > Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:419 > > + [shareMenuItem setRepresentedObject:sharingServicePicker.get()]; > > Do we need to also unset this at some point in time? (Or does it clean up > when the menu is done presenting?) We should not need to unset it, AFAICT we only use it to keep the picker alive as long as the NSMenuItem is alive.
EWS
Comment 5 2022-02-22 01:07:12 PST
Committed r290292 (247616@main): <https://commits.webkit.org/247616@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452782 [details].
Note You need to log in before you can comment on or make changes to this bug.