[iOS] WebKit app is sometimes not "Now Playing" during initial playback
<rdar://88827167>
Created attachment 452764 [details] Patch
Comment on attachment 452764 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452764&action=review > Source/WebCore/html/HTMLMediaElement.cpp:5715 > +#if USE(AUDIO_SESSION) > + m_categoryAtMostRecentPlayback = AudioSession::sharedSession().category(); > +#endif Don't we also want to do this before calling `m_player->playAtHostTime`?
(In reply to Eric Carlson from comment #3) > Comment on attachment 452764 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452764&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:5715 > > +#if USE(AUDIO_SESSION) > > + m_categoryAtMostRecentPlayback = AudioSession::sharedSession().category(); > > +#endif > > Don't we also want to do this before calling `m_player->playAtHostTime`? Good point! I'll move the setter up inside this function.
Created attachment 452767 [details] Patch for landing
Created attachment 452772 [details] Patch for landing
Created attachment 452779 [details] Patch for landing
Created attachment 452921 [details] Patch for landing
I cancelled https://ews-build.webkit.org/#/builders/73/builds/933 to speed-up mac-wk1 queue. It finished layout-test run and indicated a test failure: media/audio-session-category-at-most-recent-playback.html
Created attachment 453045 [details] Patch for landing
I cancelled https://ews-build.webkit.org/#/builders/73/builds/1061 to speed up mac-wk1 queue. It already run layout-tests and indicated this failure: media/audio-session-category-at-most-recent-playback.html
Created attachment 453393 [details] Patch for landing
Test is failing WK1 bots because `DeprecatedGlobalSettings::shouldManageAudioSessionCategory()` is false there. Will update TestExpectations and re-upload.
Created attachment 454905 [details] Patch for landing
Created attachment 455214 [details] Patch for landing
Created attachment 455216 [details] Patch for landing
Comment on attachment 455214 [details] Patch for landing iOS-wk2 bot failure is unrelated; cq+ing.
Committed r291759 (248790@main): <https://commits.webkit.org/248790@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455214 [details].