Bug 236980 – [iOS] Adjust some behaviors around the "Markup Image" action in the callout bar

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

.

[Wenson Hsieh]

Created attachment 452742 [details]
Patch

[Aditya Keerthi]

Comment on attachment 452742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452742&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:100
> +using namespace WebCore;

I think we prefer to avoid adding `using namespace` in new code, and it looks like you would just need to add prefixes to `contextMenuItemTitleMarkupImage()` below.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:317
> +    [webView objectByEvaluatingJavaScript:@"image = document.images[0]; getSelection().setBaseAndExtent(document.body, 0, image, 1);"];

Nit: I find this easier to read without the `image` variable.

(if you prefer to keep it, could use `let` for consistency with line 297)

[Wenson Hsieh]

Comment on attachment 452742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452742&action=review

Thanks for the review!

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:100
>> +using namespace WebCore;
> 
> I think we prefer to avoid adding `using namespace` in new code, and it looks like you would just need to add prefixes to `contextMenuItemTitleMarkupImage()` below.

👍🏻 Changed to just use `WebCore::` namespace prefixes.

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:317
>> +    [webView objectByEvaluatingJavaScript:@"image = document.images[0]; getSelection().setBaseAndExtent(document.body, 0, image, 1);"];
> 
> Nit: I find this easier to read without the `image` variable.
> 
> (if you prefer to keep it, could use `let` for consistency with line 297)

Good point — changed this to just `getSelection().setBaseAndExtent(document.body, 0, document.images[0], 1);`

[Wenson Hsieh]

Created attachment 452800 [details]
For landing

[EWS]

Committed r290286 (247610@main): <https://commits.webkit.org/247610@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452800 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89272083>